Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QSeek's frozen dependency audit exposed two native-loader gaps. Enchant's DLLs and dictionaries are already collected under data/mingw64, but its ZIP-backed module cannot discover that prefix. curl_cffi's compiled wrapper imports a vendor libcurl DLL from the wheel's sibling curl_cffi.libs directory, which was omitted from the artifact.
Use the shared builder's existing py2exe hooks: set the executable-relative Enchant prefix when its payload exists and neither user override is selected; add actual curl_cffi vendor DLLs through finder.add_dll, as existing NumPy/Matplotlib wheel hooks do. Older package layouts and system/explicit Enchant choices remain unchanged. No product-local hooks, dependency pins, certificate changes or skipped checks.
Validation: hosted Python 3.8 and 3.14 CI both pass all 97 tests, configured type/compatibility checks and wheel/sdist builds. The new tests execute Enchant bootcode for both architectures and cover user overrides, missing payload, older layouts, vendor DLL selection and hook registration. Full four-file review gate is complete.
Root independently reproduced the artifact Enchant import failure, then found 22 dictionaries with only a process-local prefix; the actual wrapper's PE imports identify the omitted libcurl DLL. Rebuilt native QSeek startup remains to be verified after integration.