Repository navigation
Collect compiled chardet helpers and ZIP-readable model resources - #14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A current QSeek Windows artifact builds successfully but exits during startup: html_to_text imports chardet, whose compiled pipeline extension cannot find chardet.pipeline.orchestrator__mypyc. Chardet also reads five model files through importlib.resources, so copying those beside the executable would not satisfy its ZIP-backed package layout.
Register a shared chardet hook beside the existing package hooks. It queues the root and present pipeline/models packages for py2exe's immediate-member collection and adds the actual model .bin files under their ZIP package paths. Older layouts without these subpackages continue to package normally. No product-local hook, dependency pin or native-extension disablement is introduced.
Validation: hosted Python 3.8 and 3.14 CI both pass all 87 tests and wheel/sdist builds; configured mypy and compatibility checks pass. Three new tests exercise real finder native-member enumeration, ZIP-backed importlib.resources reads, older layouts and hook registration before freezing. Full PR review gate is complete.
Native startup must still be verified in QSeek after this owner change is integrated. QSeek PR #1 remains independent of this branch.