Repository navigation
Sign and notarize Mac releases with Developer ID - #12
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mac releases are only ad-hoc signed today, so Gatekeeper blocks them. This adds Developer ID signing and notarization, driven by environment variables. With none of them set, builds behave as before.
MACOS_SIGNING_IDENTITY: after the bundle repair, every Mach-O file, nested framework version directory and nested.app/.bundleis signed inside-out with--options runtime --timestamp, then the app, thencodesign --verify --deep --strict. The.dmgis signed afterhdiutilcreates it.MACOS_SIGNING_KEYCHAIN: passed as--keychainto codesign and notarytool (the release keychain is a dedicated one, because a runner or SSH session cannot use the login keychain).MACOS_NOTARY_PROFILE: the.dmgis submitted withnotarytool submit --wait; anything butAcceptedprints Apple's log and fails the build. Then the.dmgand the app are stapled, before the update ZIP is made from the app.No entitlements are added; whether the bundled Python needs any under the hardened runtime is checked with a real notarized QCast build on the Mac Mini.
Contents/Resources/lib/python*.zipare removed (for every Mac build, signed or not). py2app copies package data such as sound_lib's BASS libraries into the zip; they cannot be loaded from there (frozen sound_lib loads the copies inContents/Resources) or signed there, and Apple's first notarization of QCast rejected exactly those files.