avoid partial UTF-8 sequences in wide-string AppendTruncated#2119
Open
nabhan06 wants to merge 1 commit into
Open
avoid partial UTF-8 sequences in wide-string AppendTruncated#2119nabhan06 wants to merge 1 commit into
nabhan06 wants to merge 1 commit into
Conversation
| EXPECT_EQ(Append(src, 4), "a"); | ||
| } | ||
|
|
||
| TEST(AppendTruncatedTest, PlainCharactersAreUnaffected) { |
Contributor
There was a problem hiding this comment.
This test appears to be broken on windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AppendTruncated encodes each wchar_t with WideToUtf8, which splits a surrogate pair across two calls and emits only the first two bytes of a four-byte sequence for the high half. Nothing checks that the pair completes, so a trailing unpaired high surrogate, a high surrogate followed by any other unit, or a valid pair straddling the truncation boundary each leave a partial sequence in the log record. This encodes U+FFFD for an unpaired high surrogate and lets a pending low surrogate use the two bytes its high half already reserved; the new test covers all three cases and fails on each without the fix.