Remove C++11 style factory function in absl::Cleanup#2042
Open
CJ-Johnson wants to merge 1 commit intoabseil:masterfrom
Open
Remove C++11 style factory function in absl::Cleanup#2042CJ-Johnson wants to merge 1 commit intoabseil:masterfrom
CJ-Johnson wants to merge 1 commit intoabseil:masterfrom
Conversation
Signed-off-by: Charles Johnson <6013273+CJ-Johnson@users.noreply.github.com>
Member
|
Hi CJ, We haven't run the CTAD cleanup on the codebase, so there is no way we can consider deleting In addition, pull requests should be focused on a single thing. Deleting a function should be isolated from unrelated changes. I did not look at the other changes. If you feel they are worth it, please say why. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the release of
absl::Cleanup, an upgrade tool has been available:Now that Abseil requires C++17 or newer, this PR removes the old spelling,
absl::MakeCleanup.This PR might not be accepted, per the "API Freeze Consequences" mentioned at https://github.com/abseil/abseil-cpp/blob/master/CONTRIBUTING.md
I wanted to propose it to see if there was any interest in removal. And while here, I made some additional changes.