Skip to content

Remove C++11 style factory function in absl::Cleanup#2042

Open
CJ-Johnson wants to merge 1 commit intoabseil:masterfrom
CJ-Johnson:charles-remove_make_cleanup
Open

Remove C++11 style factory function in absl::Cleanup#2042
CJ-Johnson wants to merge 1 commit intoabseil:masterfrom
CJ-Johnson:charles-remove_make_cleanup

Conversation

@CJ-Johnson
Copy link
Copy Markdown
Contributor

@CJ-Johnson CJ-Johnson commented Apr 26, 2026

Since the release of absl::Cleanup, an upgrade tool has been available:

Now that Abseil requires C++17 or newer, this PR removes the old spelling, absl::MakeCleanup.

This PR might not be accepted, per the "API Freeze Consequences" mentioned at https://github.com/abseil/abseil-cpp/blob/master/CONTRIBUTING.md

I wanted to propose it to see if there was any interest in removal. And while here, I made some additional changes.

Signed-off-by: Charles Johnson <6013273+CJ-Johnson@users.noreply.github.com>
@derekmauro
Copy link
Copy Markdown
Member

Hi CJ,

We haven't run the CTAD cleanup on the codebase, so there is no way we can consider deleting MakeCleanup() anytime soon.

In addition, pull requests should be focused on a single thing. Deleting a function should be isolated from unrelated changes. I did not look at the other changes. If you feel they are worth it, please say why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants