Skip to content

Fix JCalendar LGPL detected as GPL#4880

Open
Kaushik-Kumar-CEG wants to merge 1 commit intoaboutcode-org:developfrom
Kaushik-Kumar-CEG:fix-4513-jcalendar-license
Open

Fix JCalendar LGPL detected as GPL#4880
Kaushik-Kumar-CEG wants to merge 1 commit intoaboutcode-org:developfrom
Kaushik-Kumar-CEG:fix-4513-jcalendar-license

Conversation

@Kaushik-Kumar-CEG
Copy link
Copy Markdown

@Kaushik-Kumar-CEG Kaushik-Kumar-CEG commented Apr 3, 2026

Fixes #4513

JCalendar's LGPL header was getting flagged as GPL because the text is very similar to an existing GPL rule (gpl-2.0-plus_60.RULE).

Here is what this PR does to fix it:

  1. Added required phrases to the old GPL rule so it ignores the JCalendar text
  2. Added a new rule (lgpl-2.0-plus_jcalendar_1.RULE) to properly catch this specific LGPL variant
  3. Added data driven regression tests to make sure it stays fixed

Before :
image

After:
image

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

… regression test

Signed-off-by: Kaushik <kaushikrjpm10@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Correct License is not being detected

1 participant