Fix JCalendar LGPL detected as GPL#4880
Open
Kaushik-Kumar-CEG wants to merge 1 commit intoaboutcode-org:developfrom
Open
Fix JCalendar LGPL detected as GPL#4880Kaushik-Kumar-CEG wants to merge 1 commit intoaboutcode-org:developfrom
Kaushik-Kumar-CEG wants to merge 1 commit intoaboutcode-org:developfrom
Conversation
… regression test Signed-off-by: Kaushik <kaushikrjpm10@gmail.com>
b89c1f2 to
da36297
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4513
JCalendar's LGPL header was getting flagged as GPL because the text is very similar to an existing GPL rule (
gpl-2.0-plus_60.RULE).Here is what this PR does to fix it:
lgpl-2.0-plus_jcalendar_1.RULE) to properly catch this specific LGPL variantBefore :

After:

Tasks
Run tests locally to check for errors.