Skip to content

Conversation

@mollpo
Copy link
Contributor

@mollpo mollpo commented Jul 24, 2025

No description provided.

@mollpo mollpo requested a review from alexlanz July 24, 2025 06:03
@alexlanz alexlanz requested review from ThoSap and removed request for alexlanz July 24, 2025 06:09
@mollpo mollpo self-assigned this Jul 24, 2025
Copy link

@ThoSap ThoSap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can merge after this fix.
If not done already, don't forget to update the repo checklist after this.

package.json Outdated
"dist/**/*"
],
"engines": {
"npm": ">=8",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://help.readymage.com/project-development/node.js-version

npm 10 with Node.js 18
Please do a NPM install after this change

I know I forgot this in https://github.com/aboutbits/zod-locales-formatjs/pull/9/files

Suggested change
"npm": ">=8",
"npm": ">=10"

@mollpo mollpo merged commit acb4a41 into main Jul 25, 2025
6 checks passed
@mollpo mollpo deleted the node-22 branch July 25, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants