Skip to content

Refactor README to emphasize abap2UI5's flexibility and integration - #10

Merged
oblomov-dev merged 6 commits into
mainfrom
claude/readme-positive-tone-ck8lm6
Aug 11, 2026
Merged

Refactor README to emphasize abap2UI5's flexibility and integration#10
oblomov-dev merged 6 commits into
mainfrom
claude/readme-positive-tone-ck8lm6

Conversation

@oblomov-dev

Copy link
Copy Markdown
Member

Summary

Comprehensive rewrite of the README.md to better communicate the core value proposition of the samples-ext repository: demonstrating how abap2UI5 integrates with existing SAP technologies rather than replacing them.

Key Changes

  • Repositioned core messaging: Changed from "samples that need more than standalone installation" to "abap2UI5 in company with other technologies," emphasizing integration over prerequisites
  • Clarified philosophy: Added explicit statement that abap2UI5 is deliberately agnostic and flexible, working alongside RAP, OData, Smart Controls, WebSockets, and ABAP locks
  • Improved section introductions: Rewrote introductions for RAP, Smart Controls, OData, Stateful Sessions, and AMC/APC sections to emphasize complementary nature rather than dependencies
  • Enhanced setup instructions: Clarified that ABAP Platform >= 1909 is required due to EML, not as a prerequisite for abap2UI5 itself
  • Refined language throughout:
    • Changed "Needs" to "Plays together with" in the feature table
    • Replaced prescriptive language with descriptive language about what each technology offers
    • Improved readability of technical explanations
  • Added new closing section: "Where to go from here" to guide users on how to apply these samples to their own systems
  • Updated CI/CD section: Clarified that the lack of 7.02 downport is due to EML requirements, not repository design

Notable Details

  • All changes are documentation-only; no code logic was modified
  • The rewrite maintains all technical accuracy while improving clarity and tone
  • Emphasis shifted from "what you need to install" to "what technologies work well together"
  • Added more context around on-premise vs. cloud limitations (ENQUEUE, APC/AMC)

https://claude.ai/code/session_01ScVoUvxp8HoEXGC9ozxniG

…gies

Rewrite the introduction and the section openers in a positive, inviting
tone: abap2UI5 is agnostic by design and complements RAP, OData, Smart
Controls, stateful sessions, AMC/APC and the MIME repository instead of
replacing them. Prerequisites are now presented as what an area builds
on, and the remaining caveats explain expectations rather than
limitations. Technical content is unchanged.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ScVoUvxp8HoEXGC9ozxniG
Copilot AI lite review requested due to automatic review settings August 11, 2026 17:00

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

claude and others added 5 commits August 11, 2026 17:11
…package

The numbering now reads as a path into the stack: 01 OData, 02 Smart
Controls, 03 RAP, 04 RAP with Draft, 05 Business Events, 06 Stateful
Sessions/Locks, 07 AMC/APC, 08 MIME Play Audio. The Business Events
package moves next to the other two RAP packages; the child package of
RAP with Draft is renamed from 02 to 01 so every area uses the same
child number. Only folders and package descriptions move, no ABAP
object is touched.

The Business Events package had no documentation at all. It now has a
README covering the two event flavours (notification vs data event),
where they are raised, how the handler subscribes, the two abap2UI5
apps that trigger and observe them, and the LK22 naming that still
deviates from the SMPE scheme.

Each package carries its own README with the detail that used to sit in
the root file - what it builds on, its samples, its snippets. The root
README keeps the overview, the setup, the structure, the namespace and
the checks, and links into the packages from there.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ScVoUvxp8HoEXGC9ozxniG
…ud check

The package now follows the repository naming scheme, so abaplint no
longer reports it under object_naming:

  ZI_LK22_TICKET        -> Z2UI5_R_SMPE_TCK        (+ .bdef)
  ZC_LK22_TICKET        -> Z2UI5_R_SMPE_TCK_C      (+ .bdef)
  ZA_LK22_STATUSCHG     -> Z2UI5_R_SMPE_TCK_STAT
  ZI_LK22_EVTLOG        -> Z2UI5_R_SMPE_LOG
  ZBP_LK22_TICKET       -> Z2UI5_CL_SMPE_BP_TCK
  ZCL_LK22_EVT_HANDLER  -> Z2UI5_CL_SMPE_EVT_TCK
  ZCL_LK22_UI5_TICKET   -> Z2UI5_CL_SMPE_APP_11
  ZCL_LK22_UI5_EVTLOG   -> Z2UI5_CL_SMPE_APP_12
  ZLK22_TICKET/_D       -> Z2UI5_T_SMPE_TCK, Z2UI5_D_SMPE_TCK
  ZLK22_EVTLOG          -> Z2UI5_T_SMPE_LOG
  ZLK22_<field>         -> Z2UI5_E_SMPE_<field>
  ZUI_LK22_TICKET(_O4)  -> Z2UI5_SD_SMPE_TCK, Z2UI5_SB_SMPE_TCK

The namespace section documents the three tokens the scheme did not
cover yet: E for data elements, SD and SB for the service definition
and its binding. The authorization default values of the service
binding are dropped - their file name encodes a hash of the old object
name that cannot be recomputed outside an ABAP system, and publishing
the binding in ADT regenerates them.

The abap-cloud workflow and its abaplint config are removed. Several
packages here are on-premise by design, so a cloud syntax check over
the whole tree reported expected errors rather than useful ones.

Badges follow the samples repository, minus the ones that do not apply:
an abap version badge is added, abap-cloud is gone with its workflow,
and abap-702, check-rename, check-docs and the publish badges have no
counterpart in this repository.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ScVoUvxp8HoEXGC9ozxniG
The apps now sit in src/05 and the business object, its event handler
and the log stay in src/05/01 - the same split every other package
uses: what you start is one level above what it runs against.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ScVoUvxp8HoEXGC9ozxniG
Updated the description for the RAP with Draft section and removed the Structure section for clarity.
@oblomov-dev
oblomov-dev merged commit 8431956 into main Aug 11, 2026
2 of 4 checks passed
@oblomov-dev
oblomov-dev deleted the claude/readme-positive-tone-ck8lm6 branch August 11, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants