Repository navigation
Spec revision 0.3 (maintainer decisions), error.no-reflection, Adaptive Cards renderer - #2
Merged
Conversation
…ve Cards renderer - spec/open-questions.md: all ten questions decided, each with decision and rationale; the decisions applied to spec/errors.md, transport.md, actions.md and profiles/portable.md (NEST tolerated by renderers, forbidden in portable apps - the abap2UI5 linter's portable rule) - new backend check error.no-reflection (MUST): request data the backend did not validate is not reflected into the error body; both reference backends fail it (abap2UI5 1.146.0 [H] request_context_info), pinned in test/lib/expected.mjs, suite traffic recorded again - portable-v1.json: actions.api (client API) apart from actions.wire (what a renderer receives: ROUTER + options, folded names, T_CUSTOM / .eF); additive, frontendActions kept; schema, generators, generated table - renderers/adaptive-cards: response -> Adaptive Card 1.5, Action.Submit payload -> request, all 65 portable controls mapped (README table generated from mapping.mjs), card host, demo, golden cards - frontend adapter adaptive-cards: 65 pass / 0 fail / 16 skip, pinned; UI5 pin accepts portable.box-details passing (fix under way) - CI: generate check, adaptive-cards report; README, AGENTS, RESULTS, CHANGELOG Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kz1J78phfNKbqUaq3VcP4U
…ults - vendor/mcp-server at a4d9f07 (PR #44): the agent client follows every frontend rule that applies - 61 pass / 0 fail / 0 warn / 20 skip at profile semantic; the pin in test/frontend.test.mjs follows - RESULTS.md: agent row and findings (fixed), Web Components row at its main 410d607 (68 pass / 0 fail / 13 skip; model.number-and-boolean intermittent), open questions 8 and 9 note the fix Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kz1J78phfNKbqUaq3VcP4U
…pected) error.no-reflection fails on both reference backends until a node-runtime release carries the core fix; npm test pins it, the raw report steps did not. run-conformance --expected exits 0 only when the failures are exactly test/lib/expected.mjs - another failure or a pinned check that passes now still fails the step. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kz1J78phfNKbqUaq3VcP4U
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR records the maintainer's decisions on the ten open questions as spec revision 0.3, adds an Adaptive Cards renderer as a second portable renderer, and moves the agent client to the version that follows the protocol's frontend rules.
Spec revision 0.3: the open questions are decided
spec/open-questions.mdnow marks all ten as "Decided (revision 0.3)", each with its rationale and the alternatives considered. A summary table sits at the top.portable-apprule)error.no-reflectionsap-contextidportable-v1.jsongets an additiveactionsobject:api(what an app may call) andwire(what a renderer receives)Q10 detail:
frontendActionsstays and the profile version stays 1, so existing consumers keep working.portable.mdsection 6 has a generated table of client-API names against what arrives on the wire.error.no-reflectioncurrently fails on both reference backends. Both run the released@abap2ui5/node-runtime1.146.0. The core fix is in a separate abap2UI5 PR. The failure is pinned exactly intest/lib/expected.mjs, sonpm testturns red once the check starts passing and the pin has to be removed.Adaptive Cards renderer (
renderers/adaptive-cards/)Action.Submitpayload becomes the next protocol request: event, args, and the changed inputs as the model delta.host.mjsis a minimal host that speaks the protocol over HTTP.demo.mjsprints card JSON for the Adaptive Cards designer.unsupported, following the portable tolerance rule.mapping.mjs, and a test fails if it is stale.adaptive-cards: 65 pass / 0 fail / 0 warn / 16 skip at profile portable.Agent client and frontend results
a4d9f07, which is now at 61 pass / 0 fail / 0 warn / 20 skip. The five former MUST deviations are recorded as fixed.410d607): 68 pass / 0 fail / 0 warn / 13 skip.model.number-and-boolean, failed intermittently (1 of 4 full runs). Its StepInput value was missing fromMODEL, apparently because the press arrives before the input commits the value. It is filed for that repo.portable.box-detailsas passing too, since the abap2UI5 fix is in flight.Gates (local)
npm test: 59/59 pass, including the UI5 run in Chromium.npm run generate: no diff. CI now fails when it leaves a diff.npm run lint:abap: 0 issues.error.details).error.no-reflection.🤖 Generated with Claude Code
https://claude.ai/code/session_01Kz1J78phfNKbqUaq3VcP4U
Generated by Claude Code