Draft: audit performance across MudExtensions and identify focused follow-ups - #3
Closed
aarondglover wants to merge 1 commit into
Closed
aarondglover wants to merge 1 commit into
aarondglover wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
This library-wide audit is complete.
It did not identify another confirmed, measured performance defect that warrants an implementation PR.
Two areas remain as source-backed hypotheses only:
MudComboBox: repeated scans/allocations around registered items and selected-value presentation.MudJsonTreeView: possible repeated parse/serialize work and recursive-render costs.Neither was benchmarked strongly enough to justify an optimisation change.
MudTextFieldExtendedproduced no compelling candidate in the initial review.The material performance work remains focused on the existing
MudSelectExtended/MudListExtendedtrack:The audit document is retained on this branch as reference. No upstream PR is proposed from PR3B itself.
Purpose
Document a measured, library-wide performance investigation without bundling unrelated optimisations into one mega-PR. This draft currently adds
docs/performance-audit.md: initial code-backed hypotheses, benchmark requirements, regression-test scope and criteria for small follow-up PRs. No performance win is claimed in this audit PR.Initial candidates
MudComboBox: repeated scans/allocations over the registeredItemscomponents in chip/ItemContent presentation and selected-text updates; verify API and selection semantics before changing anything.MudJsonTreeView: parse/serialize and notifications in parameter setters, plus recursive rendering; profile repeated parent updates and large/nested payloads.MudTextFieldExtended: lightweight input/visualiser/validation hot-path review; no duplicate-list issue demonstrated and no speculative changes planned.Dependency and scope
Related fork PRs: #1 (virtualized selection fix), #2 (benchmark harness); follow-up PR 3 concerns the select's hidden list, while this is the separate PR 3B audit. Rebase onto fork
devafter dependencies land to use the validated harness. PR 4 (async/paged data) is out of scope.Each independently actionable improvement gets its own focused PR with equivalent before/after benchmark inputs, settled render checks, allocations/time/component counts as applicable, and protective regression tests. Keep the audit as a findings-and-links document, not an implementation catch-all.
This is fork-only and draft. Do not merge or submit upstream until the benchmark methodology, findings, and intended follow-up slices are reviewed.