Skip to content

Comments

build: prevent gen_proto.sh from hanging#736

Merged
ishymko merged 1 commit into1.0-devfrom
ishymko/npx-yes
Feb 24, 2026
Merged

build: prevent gen_proto.sh from hanging#736
ishymko merged 1 commit into1.0-devfrom
ishymko/npx-yes

Conversation

@ishymko
Copy link
Member

@ishymko ishymko commented Feb 24, 2026

According to the npx docs:

If any requested packages are not present in the local project dependencies, then they are installed to a folder in the npm cache, which is added to the PATH environment variable in the executed process. A prompt is printed (which can be suppressed by providing either --yes or --no).

Running it in non-interactive manner hangs build process and waits for keyboard input.

See #706 for potential long-term solution.

Was originally added in #696.

According to the [npx docs](https://docs.npmjs.com/cli/v8/commands/npx):

> If any requested packages are not present in the local project dependencies, then they are installed to a folder in the npm cache, which is added to the PATH environment variable in the executed process. A prompt is printed (which can be suppressed by providing either --yes or --no).

Running it in non-interactive manner hangs build process and waits for keyboard input.

See #706 for potential long-term solution.
@ishymko ishymko requested a review from a team as a code owner February 24, 2026 16:16
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ishymko, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a build issue where the gen_proto.sh script would hang due to npx waiting for user input. By adding the --yes flag to the npx command, the script now runs in a non-interactive mode, ensuring the build process completes without interruption. This change resolves a critical blocking point in the automated build flow.

Highlights

  • Build Process Fix: The gen_proto.sh script was updated to prevent it from hanging during execution by explicitly confirming npx prompts.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request addresses a critical issue where the gen_proto.sh script would hang due to npx waiting for user input. By adding the --yes flag to the npx command, the script now runs in a non-interactive manner, preventing the hang and ensuring the build process completes successfully. This is a good fix for the immediate problem.

@ishymko ishymko merged commit 59b8871 into 1.0-dev Feb 24, 2026
9 checks passed
@ishymko ishymko deleted the ishymko/npx-yes branch February 24, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants