Conversation
According to the [npx docs](https://docs.npmjs.com/cli/v8/commands/npx): > If any requested packages are not present in the local project dependencies, then they are installed to a folder in the npm cache, which is added to the PATH environment variable in the executed process. A prompt is printed (which can be suppressed by providing either --yes or --no). Running it in non-interactive manner hangs build process and waits for keyboard input. See #706 for potential long-term solution.
Summary of ChangesHello @ishymko, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a build issue where the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request addresses a critical issue where the gen_proto.sh script would hang due to npx waiting for user input. By adding the --yes flag to the npx command, the script now runs in a non-interactive manner, preventing the hang and ensuring the build process completes successfully. This is a good fix for the immediate problem.
According to the npx docs:
Running it in non-interactive manner hangs build process and waits for keyboard input.
See #706 for potential long-term solution.
Was originally added in #696.