Skip to content

fix: prevent orphan SUBMITTED rows when producer fails early #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Linux2010 wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: prevent orphan SUBMITTED rows when producer fails early #1110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
78452fb
fix: prevent orphan SUBMITTED rows when producer fails early (#1067)
Linux2010 Jun 21, 2026
62491a7
fix: add context_id to TaskStatusUpdateEvent in producer exception ha…
Linux2010 Jun 21, 2026
3c938f7
revert: remove save_task_event from producer exception handler
Linux2010 Jun 21, 2026
0aae6c8
fix: remove test for save_task_event in producer exception handler
Linux2010 Jun 21, 2026
e8178d5
style: fix ruff formatting in test file
Linux2010 Jun 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/a2a/server/agent_execution/active_task_registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
from a2a.server.context import ServerCallContext
from a2a.server.tasks.push_notification_sender import PushNotificationSender
from a2a.server.tasks.task_store import TaskStore
from a2a.types.a2a_pb2 import Message

from a2a.server.agent_execution.active_task import ActiveTask
from a2a.server.tasks.task_manager import TaskManager
Expand Down Expand Up @@ -41,6 +42,7 @@ async def get_or_create(
call_context: ServerCallContext,
context_id: str | None = None,
create_task_if_missing: bool = False,
initial_message: Message | None = None,
) -> ActiveTask:
"""Retrieves an existing ActiveTask or creates a new one."""
async with self._lock:
Expand All @@ -51,7 +53,7 @@ async def get_or_create(
task_id=task_id,
context_id=context_id,
task_store=self._task_store,
initial_message=None,
initial_message=initial_message,
context=call_context,
)

Expand Down
1 change: 1 addition & 0 deletions src/a2a/server/request_handlers/default_request_handler_v2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,7 @@ async def _setup_active_task(
context_id=context_id,
call_context=call_context,
create_task_if_missing=True,
initial_message=params.message,
)

return active_task, request_context
Expand Down
Loading