Skip to content

feat: Add tests for AUTH_REQUIRED #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kabir wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Add tests for AUTH_REQUIRED #684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63e4e4d
feat: Add tests for AUTH_REQUIRED
kabir Feb 25, 2026
a43c7c2
Gemini review
kabir Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion server-common/src/main/java/io/a2a/server/requesthandlers/DefaultRequestHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,17 @@ public EventKind onMessageSend(MessageSendParams params, ServerCallContext conte
pushConfigStore.setInfo(createdTask.id(), params.configuration().pushNotificationConfig());
}

if (blocking && interruptedOrNonBlocking) {
// Check if task requires immediate return (AUTH_REQUIRED)
// AUTH_REQUIRED expects the client to receive it immediately and handle it out-of-band,
// while the agent continues executing in the background
boolean requiresImmediateReturn = kind instanceof Task task &&
task.status().state() == io.a2a.spec.TaskState.TASK_STATE_AUTH_REQUIRED;
if (requiresImmediateReturn) {
LOGGER.debug("DefaultRequestHandler: Task {} in AUTH_REQUIRED state, skipping fire-and-forget handling",
taskId.get());
}

if (blocking && interruptedOrNonBlocking && !requiresImmediateReturn) {
// For blocking calls: ensure all consumed events are persisted to TaskStore before returning
// Order of operations is critical to avoid circular dependency and race conditions:
// 1. Wait for agent to finish enqueueing events (or timeout)
Expand Down
Loading