-
Notifications
You must be signed in to change notification settings - Fork 192
feat(api): add CompletePromptOptions parameter to completePrompt method #901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
easonLiangWorldedtech
wants to merge
3
commits into
Zoo-Code-Org:main
Choose a base branch
from
easonLiangWorldedtech:feat/abort-signal-core/complete-prompt
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
bcedf50
feat(api): add CompletePromptOptions parameter to completePrompt method
easonliang28 7785da5
test(fake-ai): add test coverage for countTokens and completePrompt d…
easonliang28 62ed671
refactor(Task.spec): simplify mockStreamFactory to standard async gen…
easonliang28 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| import type { Anthropic } from "@anthropic-ai/sdk" | ||
|
|
||
| import type { ApiHandlerCreateMessageMetadata, CompletePromptOptions } from "../../index" | ||
| import { FakeAIHandler } from "../fake-ai" | ||
|
|
||
| const modelInfo = { | ||
| contextWindow: 8192, | ||
| maxTokens: 4096, | ||
| supportsImages: false, | ||
| supportsPromptCache: false, | ||
| } | ||
|
|
||
| describe("FakeAIHandler", () => { | ||
| it("should delegate completePrompt with options to the cached FakeAI instance", async () => { | ||
| const completePrompt = vitest.fn().mockResolvedValue("delegated response") | ||
| const fakeAi: { | ||
| id: string | ||
| createMessage: () => AsyncGenerator<never, void, unknown> | ||
| getModel: () => { id: string; info: typeof modelInfo } | ||
| countTokens: ReturnType<typeof vitest.fn> | ||
| completePrompt: typeof completePrompt | ||
| removeFromCache?: () => void | ||
| } = { | ||
| id: "fake-ai-completePrompt-delegation", | ||
| createMessage: async function* () {}, | ||
| getModel: () => ({ id: "fake-model", info: modelInfo }), | ||
| countTokens: vitest.fn().mockResolvedValue(0), | ||
| completePrompt, | ||
| } | ||
| const controller = new AbortController() | ||
| const options: CompletePromptOptions = { abortSignal: controller.signal, timeoutMs: 1234 } | ||
|
|
||
| const handler = new FakeAIHandler({ fakeAi }) | ||
| const result = await handler.completePrompt("Test prompt", options) | ||
|
|
||
| expect(result).toBe("delegated response") | ||
| expect(completePrompt).toHaveBeenCalledWith("Test prompt", options) | ||
| fakeAi.removeFromCache?.() | ||
| }) | ||
|
|
||
| it("should delegate createMessage, getModel, and countTokens to FakeAI", async () => { | ||
| const metadata = { taskId: "task-1" } as ApiHandlerCreateMessageMetadata | ||
| const messages: Anthropic.Messages.MessageParam[] = [{ role: "user", content: "Hello" }] | ||
| const content: Anthropic.Messages.ContentBlockParam[] = [{ type: "text", text: "Hello" }] | ||
| const createMessage = vitest.fn(async function* () { | ||
| yield { type: "text" as const, text: "Hello" } | ||
| }) | ||
| const getModel = vitest.fn(() => ({ id: "fake-model", info: modelInfo })) | ||
| const countTokens = vitest.fn().mockResolvedValue(7) | ||
| const fakeAi: { | ||
| id: string | ||
| createMessage: typeof createMessage | ||
| getModel: typeof getModel | ||
| countTokens: typeof countTokens | ||
| completePrompt: ReturnType<typeof vitest.fn> | ||
| removeFromCache?: () => void | ||
| } = { | ||
| id: "fake-ai-handler-delegation", | ||
| createMessage, | ||
| getModel, | ||
| countTokens, | ||
| completePrompt: vitest.fn().mockResolvedValue("complete"), | ||
| } | ||
|
|
||
| const handler = new FakeAIHandler({ fakeAi }) | ||
| const chunks = [] | ||
| for await (const chunk of handler.createMessage("System", messages, metadata)) { | ||
| chunks.push(chunk) | ||
| } | ||
|
|
||
| expect(chunks).toEqual([{ type: "text", text: "Hello" }]) | ||
| expect(createMessage).toHaveBeenCalledWith("System", messages, metadata) | ||
| expect(handler.getModel()).toEqual({ id: "fake-model", info: modelInfo }) | ||
| expect(getModel).toHaveBeenCalledTimes(1) | ||
| await expect(handler.countTokens(content)).resolves.toBe(7) | ||
| expect(countTokens).toHaveBeenCalledWith(content) | ||
| fakeAi.removeFromCache?.() | ||
| }) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.