Skip to content

chore: add flaky test detection to Playwright #2358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rrewll wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore: add flaky test detection to Playwright #2358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a09a45d
chore: add flaky test detection to Playwright
rrewll Nov 8, 2026
0d1ee8e
Remove retryStrategy from Playwright config
rrewll Nov 8, 2026
73e70c5
Reduce retries from 3 to 2 in Playwright config
rrewll Nov 8, 2026
f5dec02
Increase web-visual timeout to 15 minutes
rrewll Nov 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/visual-regression.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ permissions:
jobs:
webview-visual:
runs-on: ubuntu-latest
timeout-minutes: 10
timeout-minutes: 15
container:
image: mcr.microsoft.com/playwright:v1.64.1-noble@sha256:47b510dd9230bf0b9bfc9b20102241e577ea7a99334ab4c3ca19f19770e9b8ea
options: --ipc=host
Expand Down
2 changes: 2 additions & 0 deletions webview-ui/playwright-ct.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,6 @@ export default defineConfig({
url: galleryUrl,
reuseExistingServer: !process.env.CI,
},
retries: 2,
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Resolved
failOnFlakyTests: true,

@edelauna edelauna Nov 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With failOnFlakyTests: true, does a test that passes on retry still fail the job? In run 42453772004 the report shows Flaky 1, Failed 0, but the webview-visual job ended with failure. If you want CI to tolerate flakes, should this be false? If you want to keep it, could the description say that a flaky test still fails the job?

})
Loading