fix: remove client-side role checks to prevent privilege escalation #9
Closed
wicky-zipstack wants to merge 2 commits intomainfrom
Closed
fix: remove client-side role checks to prevent privilege escalation #9wicky-zipstack wants to merge 2 commits intomainfrom
wicky-zipstack wants to merge 2 commits intomainfrom
Conversation
…ia session interception - Profile.jsx: remove Role field display that showed intercepted role from session store
…ause of privilege escalation The checkPermission() function in helpers.js had a shortcut that returned true for all permission checks if user_role === "visitran_super_admin". Since user_role is read from localStorage (editable by user), this allowed any user to bypass all frontend permission checks by modifying their session data. Now always uses server-returned permissions from permissionDetails store.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
user_role === "visitran_super_admin"checks from MenuTree.jsx and route-component.jsxWhy
How
MenuTree.jsx: Removed
userRole === "visitran_super_admin"condition. UAC menu items now show based only on whether the plugin component exists (hasRoles,hasResources, etc.). In OSS, plugins don't exist so menu items don't show. In cloud, backend returns 403 on the actual data endpoints for unauthorized users (PR #310 on cloud repo).Profile.jsx: Removed Role field that displayed
sessionDetails.user_role(interceptable). RemoveduseSessionStoredependency.Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
try/requirefails, components are undefined, routes and menu items don't render. Same behavior as before.Database Migrations
None
Env Config
None
Related Issues or PRs
Notes on Testing
Checklist