Repository navigation
LW-474 [CHORE] Sync to llmwhisperer-client 2.10.0 - #21
Open
johnyrahul wants to merge 1 commit into
Open
johnyrahul wants to merge 1 commit into
johnyrahul wants to merge 1 commit into
Conversation
Move the exact pin, the vendored spec and its provenance together, as a client bump has to: the CLI derives its flags from the spec and can only offer what the pinned client accepts. The spec is copied byte-for-byte from `specs/llmwhisperer.json` at the client's v2.10.0 tag, which its `tools/gen_sdk.sh` records as upstream `Zipstack/unstract-llm-whisperer` 9fe7085b44da6ca37e635fba3ab082c725ef8aef. The one parameter 2.10.0 adds, `include_cell_borders`, derives into `whisper extract` as a paired `--include-cell-borders/--no-include-cell-borders` flag, so `derived_flags.json` gains that entry and nothing else -- no flag lost, no choice or type narrowed. Its help comes from the client's own docstring, which states that the parameter keys off the uploaded file type rather than the mode. Like the existing `--allow-rotated-text`, the spec defaults it to true while the client defaults it to None, so omitting the flag sends nothing and the server's default applies. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
[Low impact] The PR appears safe to merge; no actionable defects were found.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps the exact
llmwhisperer-clientpin to 2.10.0 and re-syncs the vendored LLMWhisperer spec and its provenance to match, per thebump-client-pinsskill.The pin, the spec and
provenance.jsonmove in one commit because they are coupled: the CLI derives its flags and help text from the vendored spec, intersected with what the pinned client actually accepts.The chain
The spec is copied byte-for-byte from
specs/llmwhisperer.jsonat the client'sv2.10.0tag. That tag'stools/gen_sdk.shrecords the source asZipstack/unstract-llm-whisperer@9fe7085b44da6ca37e635fba3ab082c725ef8aef— the squash commit of the matching service PR — so that is whatprovenance.jsonnow records, alongside the new sha256.Surface change
2.10.0 adds exactly one optional parameter,
include_cell_borders, and the spec declares it as a non-internal, non-deprecated query parameter the pinned client accepts. So it derives automatically intowhisper extractas a paired flag:tests/derived_flags.jsongains that one entry and nothing else — no flag lost, no choice or type narrowed. The snapshot was refreshed deliberately after reading the named difference.Help text falls through to the client's own docstring, which states that the parameter keys off the uploaded file type (any XLS/XLSX upload, the default
formmode included) rather than offmode, so nooverlay.tomlentry was needed to reword it.As with the existing
--allow-rotated-text, the spec defaults this totruewhile the client defaults it toNone: omitting the flag sends nothing and the server's default applies. The new flag also appears in the--discover fullcontract.Verification
uv lock+uv sync --extra dev --python 3.12— lockfile updated (2.9.1 → 2.10.0)uv run pytest -q— 569 passed, 1 skippeduv run ruff check .anduv run ruff format --check .— clean, 38 files already formatted__version__is deliberately left alone;release.ymlowns the bump at dispatch.🤖 Generated with Claude Code