🐛 fix(desktop): 声明 Windows NSIS 发行图标 - #137
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
关联 Issue
Closes #136
做了什么
bundle配置中显式声明icons/icon.ico,供 Windows NSIS bundler 使用。实现与架构
v0.1.0的 NSIS、统一 ZIP、SHA256 校验和与 GitHub Release。实验记录
实验:检查发布 run
34546468025的 Windows 日志,定位 Tauri 编译成功后在 NSIS 阶段报Couldn't find a .ico icon;确认desktop/src-tauri/icons/icon.ico已存在但未在 bundle 配置声明。结果:补充
bundle.icon指向现有 ICO;本地桌面 Vite/typecheck 构建保持通过,NSIS 由 Windows runner 验证。结论:修复发布元数据缺失,若 ICO 格式仍被 bundler 拒绝,再另行更换经过验证的多尺寸 ICO,不在本 PR 扩大范围。
验证
风险与回滚
v0.1.0tag 或 Maven Package。提交前检查