ensure codeblocks are closed#589
Open
graphiteisaac wants to merge 1 commit into
Open
Conversation
This is really quite hard to test, but I think this should be able to fix the case reason codeblock problem we run into on the Overwatch server fairly often
|
Thank you for contributing to Zeppelin! We require contributors to sign our Contributor License Agreement (CLA). To let us review and merge your code, please visit https://github.com/ZeppelinBot/CLA to sign the CLA! |
Author
|
Have since signed and PRed the CLA. |
Contributor
Hi, your PR needs to point to ZeppelinBot/CLA:main, not your fork, then it can get merged and approved. |
Collaborator
|
@cla-bot check |
|
Thank you for contributing to Zeppelin! We require contributors to sign our Contributor License Agreement (CLA). To let us review and merge your code, please visit https://github.com/ZeppelinBot/CLA to sign the CLA! |
|
The cla-bot has been summoned, and re-checked this pull request! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is really quite hard to test, but I think this should be able to fix the case reason codeblock problem we run into on the Overwatch server fairly often, eg:
If there's any proper testing I can do, or some way to clearly reproduce the issue, I'd be more than happy to try to do that and battle-test this a bit more.