Repository navigation
ci(release): run CI on release PRs - #48
Merged
Merged
Conversation
Release PRs come from GITHUB_TOKEN, so GitHub starts no workflows on them. The release workflow now starts CI on each open release PR, so its checks run before the merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release PRs are opened with the built-in GitHub token, so GitHub starts no workflows on them and asks for a manual approval. The release workflow now starts CI on each open release PR itself, so its checks run before the merge. No new secret.
Changes
release.yml: after release-please opens or updates its PR, the job runsci.ymlon each open release PR branch (actions: write).ci.yml: aworkflow_dispatchtrigger, so it can be started that way.The "workflows awaiting approval" note still shows on release PRs; CI has already run, so it can be ignored.