Repository navigation
ci(release): release only from real release PRs and released tags - #46
Merged
Merged
Conversation
A push now counts as a release only when it merges a PR that github-actions[bot] opened with an autorelease label, not any branch named like a release PR. A manual run publishes only a tag on main that has a GitHub release, and only from main. Both close ways to publish without the release PR, now that the release environment has no reviewers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two checks so that only the release PR leads to a publish. This prepares a release flow where merging the release PR is the only step, with no second approval.
Changes
github-actions[bot]and carry anautorelease:label. A branch named like a release PR is no longer enough, because anyone with write access can name a branch.main, and the tag must be onmainand have a GitHub release. A tag made by hand on an unreviewed commit is refused.Checks
actionlint passes. The new release filter matches the last release PR and rejects a normal PR.