Repository navigation
ci(release): release with release-please - #41
Merged
Merged
Conversation
The CLI was versioned and published to npm by hand. release-please now opens a release PR from Conventional Commit titles and sets the version in package.json, package-lock.json and CLI_VERSION. Merging that PR tags, creates the GitHub release and publishes to npm with trusted publishing. The npm version script and its sync script are no longer needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Releases now come from release-please. Merging the
chore: release X.Y.ZPR releases: the workflow checks and builds with read-only rights, then creates the tag and the GitHub release with generated notes, and publishes to npm with trusted publishing.What changes for maintainers
fix,featandperfneed a lowercase scope, for examplefix(crawl): .... They set the version:fixpatch,featminor,!major.fix,feat,perfandrevertPRs lead to a release.docs,chore,test,ci,refactor,buildandstyledo not..github/andrelease-please-config.jsonneed a review from@ZenRows/prod-approvers.Notes
CLI_VERSIONinsrc/core/config.ts; theversionscript is removed.