Repository navigation
Python: Prefer injected Qdrant clients over connection settings - #2
Closed
ZedingZhang wants to merge 2 commits into
Closed
ZedingZhang wants to merge 2 commits into
ZedingZhang wants to merge 2 commits into
Conversation
An injected AsyncQdrantClient now takes precedence over URL, API key, and .env options. Those settings are not read, and the caller keeps ownership even when managed_client is true. Fixes microsoft#9957 Co-authored-by: ZedingZhang <me@zedingzhang.com>
ZedingZhang
had a problem deploying
to
github-app-auth
November 2, 2026 18:51 — with
GitHub Actions
Failure
ZedingZhang
had a problem deploying
to
github-app-auth
November 2, 2026 18:52 — with
GitHub Actions
Failure
QdrantCollection now runs base initialization before resolving a client, so invalid collection arguments raise without calling the SDK factory. Co-authored-by: ZedingZhang <me@zedingzhang.com>
ZedingZhang
had a problem deploying
to
github-app-auth
November 2, 2026 19:01 — with
GitHub Actions
Failure
Owner
Author
|
Closing: the same change already landed upstream as microsoft#9993 (merged 2026-11-03). |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
QdrantStoreandQdrantCollectionraiseValueErrorwhen an injectedAsyncQdrantClientis supplied alongside URL, API-key, or.envoptions. They also honormanaged_client=Trueby closing that caller-supplied client. Applications cannot reuse a configured client together with shared constructor options, and cleanup can close a client the caller still owns.Description & Review Guide
.envloading for that client, and always leave it caller-owned, including whenmanaged_client=True. Update the constructor documentation, README, and the settings and ownership tests.load_settingsandAsyncQdrantClientare not called for an injected client, and confirm cleanup leaves that client open. The regression fails on the original implementation and passes with the fix.Related Issue
Fixes microsoft#9957. The issue has the
ready-for-implementationlabel; no competing open PR was found before submission.AI Assistance
AI assistance details: An AI coding assistant helped with investigation, implementation, tests, documentation, and this PR description.
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.