Skip to content

[NDGL-125] chore: NDGLChipTab을 LazyRow로 변경 및 contentPadding 적용#42

Merged
jihee-dev merged 1 commit intodevelopfrom
feature/NDGL-125/add-chip-tab-content-padding
Feb 27, 2026
Merged

[NDGL-125] chore: NDGLChipTab을 LazyRow로 변경 및 contentPadding 적용#42
jihee-dev merged 1 commit intodevelopfrom
feature/NDGL-125/add-chip-tab-content-padding

Conversation

@jihee-dev
Copy link
Copy Markdown
Member

@jihee-dev jihee-dev commented Feb 27, 2026

NDGL-125 chore: NDGLChipTab을 LazyRow로 변경 및 contentPadding 적용


연관 문서

변경사항

-NDGLChipTab LazyRow 변경 및 contentPadding 적용

  • 홈 - 인기 여행 섹션 탭
  • 인기 여행 목록 페이지 탭
  • 여행 따라가기 일차 탭
  • 내 여행 일차 탭

테스트 체크 리스트

  • 홈 - 인기 여행 섹션 탭
  • 인기 여행 목록 페이지 탭
  • 여행 따라가기 일차 탭
  • 내 여행 일차 탭

Summary by CodeRabbit

릴리스 노트

  • 리팩토링
    • 탭 레이아웃의 성능을 최적화하여 스크롤 처리를 개선했습니다.
    • 패딩 적용 방식을 개선하여 컴포넌트 구조를 더욱 효율적으로 정렬했습니다.

@jihee-dev jihee-dev self-assigned this Feb 27, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 27, 2026

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

개요

NDGLChipTab 컴포넌트가 일반 Row에서 LazyRow로 변경되고 contentPadding 파라미터가 추가되었습니다. 4개의 화면 파일이 새로운 contentPadding 파라미터를 사용하도록 업데이트되었습니다.

변경 사항

Cohort / File(s) 요약
Core UI - NDGLChipTab 리팩토링
core/ui/src/main/java/com/yapp/ndgl/core/ui/designsystem/NDGLChipTab.kt
Row에서 LazyRow로 변경하고 rememberScrollState 및 수동 스크롤 로직 제거. 새로운 contentPadding: PaddingValues 파라미터 추가하여 LazyRow에 전달. itemsIndexed를 사용하여 탭 렌더링 방식 변경.
Home 기능 화면
feature/home/src/main/java/com/yapp/ndgl/feature/home/main/PopularTravelSection.kt, feature/home/src/main/java/com/yapp/ndgl/feature/home/popular/PopularTravelListScreen.kt
NDGLChipTab 수정자에서 시작 패딩(start = 24.dp) 제거하고 contentPadding = PaddingValues(horizontal = 24.dp)으로 대체. 패딩 적용 방식을 컨테이너에서 컴포넌트 파라미터로 변경.
Travel 기능 화면
feature/travel/src/main/java/com/yapp/ndgl/feature/travel/followtravel/FollowTravelScreen.kt, feature/travel/src/main/java/com/yapp/ndgl/feature/travel/traveldetail/TravelDetailScreen.kt
모듈 수정자에서 수평 패딩 제거하고 NDGLChipTab에 contentPadding = PaddingValues(horizontal = 24.dp) 파라미터 추가. 패딩 책임을 수정자에서 컴포넌트 파라미터로 이전.

예상 코드 리뷰 노력

🎯 2 (단순) | ⏱️ ~12분

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed PR 제목은 주요 변경사항을 명확하게 요약합니다. NDGLChipTab을 LazyRow로 변경하고 contentPadding을 적용하는 핵심 변경 사항을 정확하게 반영하고 있습니다.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/NDGL-125/add-chip-tab-content-padding

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@core/ui/src/main/java/com/yapp/ndgl/core/ui/designsystem/NDGLChipTab.kt`:
- Around line 56-59: The LazyRow itemsIndexed call in NDGLChipTab uses tab.tag
as the key which can be non-unique (Preview data uses tag = "1"), causing
IllegalArgumentException; update the key lambda in itemsIndexed (the call that
passes items = tabs and key = { _, tab -> tab.tag }) to produce a unique key per
item (for example combine index and tag or use the index: key = { index, tab ->
"${index}-${tab.tag}" } or key = { index, _ -> index }) so each item in
itemsIndexed has a stable, unique key.

ℹ️ Review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f042d3f and 9ea9d1f.

📒 Files selected for processing (5)
  • core/ui/src/main/java/com/yapp/ndgl/core/ui/designsystem/NDGLChipTab.kt
  • feature/home/src/main/java/com/yapp/ndgl/feature/home/main/PopularTravelSection.kt
  • feature/home/src/main/java/com/yapp/ndgl/feature/home/popular/PopularTravelListScreen.kt
  • feature/travel/src/main/java/com/yapp/ndgl/feature/travel/followtravel/FollowTravelScreen.kt
  • feature/travel/src/main/java/com/yapp/ndgl/feature/travel/traveldetail/TravelDetailScreen.kt

@jihee-dev jihee-dev force-pushed the feature/NDGL-125/add-chip-tab-content-padding branch from 9ea9d1f to e72d667 Compare February 27, 2026 16:20
@jihee-dev jihee-dev merged commit 9625881 into develop Feb 27, 2026
4 checks passed
@jihee-dev jihee-dev deleted the feature/NDGL-125/add-chip-tab-content-padding branch February 27, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant