Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
개요NDGLChipTab 컴포넌트가 일반 Row에서 LazyRow로 변경되고 contentPadding 파라미터가 추가되었습니다. 4개의 화면 파일이 새로운 contentPadding 파라미터를 사용하도록 업데이트되었습니다. 변경 사항
예상 코드 리뷰 노력🎯 2 (단순) | ⏱️ ~12분 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@core/ui/src/main/java/com/yapp/ndgl/core/ui/designsystem/NDGLChipTab.kt`:
- Around line 56-59: The LazyRow itemsIndexed call in NDGLChipTab uses tab.tag
as the key which can be non-unique (Preview data uses tag = "1"), causing
IllegalArgumentException; update the key lambda in itemsIndexed (the call that
passes items = tabs and key = { _, tab -> tab.tag }) to produce a unique key per
item (for example combine index and tag or use the index: key = { index, tab ->
"${index}-${tab.tag}" } or key = { index, _ -> index }) so each item in
itemsIndexed has a stable, unique key.
ℹ️ Review info
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
core/ui/src/main/java/com/yapp/ndgl/core/ui/designsystem/NDGLChipTab.ktfeature/home/src/main/java/com/yapp/ndgl/feature/home/main/PopularTravelSection.ktfeature/home/src/main/java/com/yapp/ndgl/feature/home/popular/PopularTravelListScreen.ktfeature/travel/src/main/java/com/yapp/ndgl/feature/travel/followtravel/FollowTravelScreen.ktfeature/travel/src/main/java/com/yapp/ndgl/feature/travel/traveldetail/TravelDetailScreen.kt
9ea9d1f to
e72d667
Compare
NDGL-125 chore: NDGLChipTab을 LazyRow로 변경 및 contentPadding 적용
연관 문서
변경사항
-NDGLChipTab LazyRow 변경 및 contentPadding 적용
테스트 체크 리스트
Summary by CodeRabbit
릴리스 노트