[NDGL-123] 다가오는 여행 카드 디데이 및 썸네일 이슈 수정#40
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
Walkthrough이 변경 사항은 여행 데이터 모델에 Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@feature/home/src/main/java/com/yapp/ndgl/feature/home/main/UpcomingTravelCardSection.kt`:
- Around line 187-191: The D-Day branch in UpcomingTravelCardSection uses if
(dDay > 0) ... else ... so update the preview/sample data in this file to use a
positive dDay value (e.g., change dDay from -7 to 7) so the preview exercises
the same branch as the runtime condition; locate the preview/sample provider in
UpcomingTravelCardSection.kt where dDay is set for the preview and replace the
negative value with a positive one to keep preview output consistent with the
code path.
ℹ️ Review info
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (15)
data/travel/src/main/java/com/yapp/ndgl/data/travel/model/TravelTemplateSummary.ktfeature/home/src/main/java/com/yapp/ndgl/feature/home/component/TravelTemplate.ktfeature/home/src/main/java/com/yapp/ndgl/feature/home/main/HomeScreen.ktfeature/home/src/main/java/com/yapp/ndgl/feature/home/main/HomeViewModel.ktfeature/home/src/main/java/com/yapp/ndgl/feature/home/main/PopularTravelSection.ktfeature/home/src/main/java/com/yapp/ndgl/feature/home/main/RecommendedContentSection.ktfeature/home/src/main/java/com/yapp/ndgl/feature/home/main/UpcomingTravelCardSection.ktfeature/home/src/main/java/com/yapp/ndgl/feature/home/model/TravelContent.ktfeature/home/src/main/java/com/yapp/ndgl/feature/home/popular/PopularTravelListViewModel.ktfeature/home/src/main/java/com/yapp/ndgl/feature/home/search/TemplateSearchScreen.ktfeature/home/src/main/java/com/yapp/ndgl/feature/home/search/TemplateSearchViewModel.ktfeature/travel-helper/src/main/java/com/yapp/ndgl/feature/travelhelper/main/UpcomingTravelCardSection.ktfeature/travel/src/main/java/com/yapp/ndgl/feature/travel/mytravel/MyTravelViewModel.ktfeature/travel/src/main/java/com/yapp/ndgl/feature/travel/mytravel/UpcomingTravelCardSection.ktfeature/travel/src/main/java/com/yapp/ndgl/feature/travel/mytravel/UpcomingTravelListSection.kt
feature/home/src/main/java/com/yapp/ndgl/feature/home/main/UpcomingTravelCardSection.kt
Show resolved
Hide resolved
b5d584f to
294e709
Compare
NDGL-123 다가오는 여행 카드 디데이 및 썸네일 이슈 수정
연관 문서
변경사항
테스트 체크 리스트
Summary by CodeRabbit
릴리스 노트
새로운 기능
버그 수정
스타일