Skip to content

[NDGL-123] 다가오는 여행 카드 디데이 및 썸네일 이슈 수정#40

Merged
jihee-dev merged 2 commits intodevelopfrom
feature/NDGL-123/fix-upcoming-travel-card-issue
Feb 27, 2026
Merged

[NDGL-123] 다가오는 여행 카드 디데이 및 썸네일 이슈 수정#40
jihee-dev merged 2 commits intodevelopfrom
feature/NDGL-123/fix-upcoming-travel-card-issue

Conversation

@jihee-dev
Copy link
Copy Markdown
Member

@jihee-dev jihee-dev commented Feb 27, 2026

NDGL-123 다가오는 여행 카드 디데이 및 썸네일 이슈 수정


연관 문서

변경사항

  • TravelContent 및 관련 UI에 국가명(countryName) 필드 추가 및 적용
  • 여행 카드 D-Day 표시 로직 및 썸네일 이미지 경로 수정

테스트 체크 리스트

  • 인기 여행 아이템 국가명 노출 확인
  • 다가오는 여행 카드 D-Day 정상 노출 확인
  • 다가오는 여행 썸네일 이미지 확인

Summary by CodeRabbit

릴리스 노트

  • 새로운 기능

    • 여행 정보에 국가명 표시 기능 추가
  • 버그 수정

    • D-Day 표시 조건 로직 수정
  • 스타일

    • DayTag 배지 모양을 원형으로 변경하여 UI 일관성 개선

@jihee-dev jihee-dev self-assigned this Feb 27, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 27, 2026

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

이 변경 사항은 여행 데이터 모델에 countryName 필드를 추가하고, 홈 화면 및 검색 기능의 여러 뷰 모델과 컴포넌트에서 이를 전파합니다. 또한 일부 여행 카드 컴포넌트의 DayTag 시각적 표현을 개선하고, D-Day 조건 로직을 조정합니다.

Changes

Cohort / File(s) Summary
데이터 모델 확장 - countryName 필드 추가
data/travel/src/main/java/com/yapp/ndgl/data/travel/model/TravelTemplateSummary.kt, feature/home/src/main/java/com/yapp/ndgl/feature/home/model/TravelContent.kt
TravelTemplateSummary 및 TravelContent 데이터 클래스에 새로운 공개 필드 countryName: String을 추가하여 데이터 구조를 확장합니다.
홈 화면 - countryName 전파
feature/home/src/main/java/com/yapp/ndgl/feature/home/main/HomeScreen.kt, feature/home/src/main/java/com/yapp/ndgl/feature/home/main/HomeViewModel.kt
HomeViewModel에서 TravelContent 구성 시 countryName을 추가하고, HomeScreen 프리뷰에서 countryName 값을 전달합니다.
인기 여행지 섹션 - 데이터 매핑 업데이트
feature/home/src/main/java/com/yapp/ndgl/feature/home/main/PopularTravelSection.kt, feature/home/src/main/java/com/yapp/ndgl/feature/home/popular/PopularTravelListViewModel.kt
TravelTemplateSummary에서 TravelContent로 매핑할 때 countryName을 포함시키고, 프리뷰 데이터에 해당 국가명을 초기화합니다.
추천 콘텐츠 섹션 - countryName 초기화
feature/home/src/main/java/com/yapp/ndgl/feature/home/main/RecommendedContentSection.kt
RecommendedContentSectionPreview에서 TravelContent 인스턴스 생성 시 countryName을 포함시킵니다.
템플릿 검색 화면 - 검색 기능 업데이트
feature/home/src/main/java/com/yapp/ndgl/feature/home/search/TemplateSearchScreen.kt, feature/home/src/main/java/com/yapp/ndgl/feature/home/search/TemplateSearchViewModel.kt
TemplateSearchViewModel의 TravelContent 매핑에 countryName을 추가하고, 검색 화면 프리뷰에서 countryName 값을 초기화합니다.
여행 템플릿 표시 - 국가명 변경
feature/home/src/main/java/com/yapp/ndgl/feature/home/component/TravelTemplate.kt
TravelTemplate 컴포넌트에서 국가 표시 텍스트를 travel.country에서 travel.countryName으로 변경합니다.
DayTag UI 개선 - 원형 배지로 변경
feature/home/src/main/java/com/yapp/ndgl/feature/home/main/UpcomingTravelCardSection.kt, feature/travel-helper/src/main/java/com/yapp/ndgl/feature/travelhelper/main/UpcomingTravelCardSection.kt, feature/travel/src/main/java/com/yapp/ndgl/feature/travel/mytravel/UpcomingTravelListSection.kt
DayTag의 배경 모양을 RoundedCornerShape(999.dp)에서 CircleShape으로 변경하여 완전히 원형의 배지로 표시합니다.
D-Day 조건 로직 수정
feature/home/src/main/java/com/yapp/ndgl/feature/home/main/UpcomingTravelCardSection.kt, feature/travel-helper/src/main/java/com/yapp/ndgl/feature/travelhelper/main/UpcomingTravelCardSection.kt, feature/travel/src/main/java/com/yapp/ndgl/feature/travel/mytravel/UpcomingTravelCardSection.kt
D-Day 조건부 로직을 반전시켜 dDay > 0일 때 마이너스 접두사 문자열을 선택하도록 변경합니다.
이미지 URL 소스 간소화
feature/home/src/main/java/com/yapp/ndgl/feature/home/main/HomeViewModel.kt, feature/travel/src/main/java/com/yapp/ndgl/feature/travel/mytravel/MyTravelViewModel.kt
업커밍 여행의 이미지 URL을 travel.thumbnail로 직접 참조하도록 변경하여 중첩된 옵셔널 접근을 제거합니다.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed PR 제목이 변경사항의 주요 내용을 명확하게 설명합니다. D-Day 로직 수정, 썸네일 이슈 해결, 그리고 국가명 필드 추가라는 세 가지 주요 변경사항을 모두 포함하고 있습니다.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/NDGL-123/fix-upcoming-travel-card-issue

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@feature/home/src/main/java/com/yapp/ndgl/feature/home/main/UpcomingTravelCardSection.kt`:
- Around line 187-191: The D-Day branch in UpcomingTravelCardSection uses if
(dDay > 0) ... else ... so update the preview/sample data in this file to use a
positive dDay value (e.g., change dDay from -7 to 7) so the preview exercises
the same branch as the runtime condition; locate the preview/sample provider in
UpcomingTravelCardSection.kt where dDay is set for the preview and replace the
negative value with a positive one to keep preview output consistent with the
code path.

ℹ️ Review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3b96dca and b5d584f.

📒 Files selected for processing (15)
  • data/travel/src/main/java/com/yapp/ndgl/data/travel/model/TravelTemplateSummary.kt
  • feature/home/src/main/java/com/yapp/ndgl/feature/home/component/TravelTemplate.kt
  • feature/home/src/main/java/com/yapp/ndgl/feature/home/main/HomeScreen.kt
  • feature/home/src/main/java/com/yapp/ndgl/feature/home/main/HomeViewModel.kt
  • feature/home/src/main/java/com/yapp/ndgl/feature/home/main/PopularTravelSection.kt
  • feature/home/src/main/java/com/yapp/ndgl/feature/home/main/RecommendedContentSection.kt
  • feature/home/src/main/java/com/yapp/ndgl/feature/home/main/UpcomingTravelCardSection.kt
  • feature/home/src/main/java/com/yapp/ndgl/feature/home/model/TravelContent.kt
  • feature/home/src/main/java/com/yapp/ndgl/feature/home/popular/PopularTravelListViewModel.kt
  • feature/home/src/main/java/com/yapp/ndgl/feature/home/search/TemplateSearchScreen.kt
  • feature/home/src/main/java/com/yapp/ndgl/feature/home/search/TemplateSearchViewModel.kt
  • feature/travel-helper/src/main/java/com/yapp/ndgl/feature/travelhelper/main/UpcomingTravelCardSection.kt
  • feature/travel/src/main/java/com/yapp/ndgl/feature/travel/mytravel/MyTravelViewModel.kt
  • feature/travel/src/main/java/com/yapp/ndgl/feature/travel/mytravel/UpcomingTravelCardSection.kt
  • feature/travel/src/main/java/com/yapp/ndgl/feature/travel/mytravel/UpcomingTravelListSection.kt

@jihee-dev jihee-dev force-pushed the feature/NDGL-123/fix-upcoming-travel-card-issue branch from b5d584f to 294e709 Compare February 27, 2026 15:20
@jihee-dev jihee-dev merged commit 685d988 into develop Feb 27, 2026
4 checks passed
@jihee-dev jihee-dev deleted the feature/NDGL-123/fix-upcoming-travel-card-issue branch February 27, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant