[Refactor/#177] domain, presentation 계층간 model mapper를 구현합니다.#178
Open
[Refactor/#177] domain, presentation 계층간 model mapper를 구현합니다.#178
Conversation
- nullable이던 TodayEmotion을 non-null인 DailyEmotion으로 변경하고, 감정 등록 여부를 나타내는 `hasEmotion` 프로퍼티를 추가했습니다. - `emotionMarbleType`을 String에서 `EmotionMarbleType` enum 클래스로 변경하여 타입 안정성을 강화했습니다. - 관련 클래스 및 변수명을 `TodayEmotion`에서 `DailyEmotion`으로 일괄 변경했습니다. (`fetchTodayEmotion` -> `fetchDailyEmotion`)
- DayRoutinesUiModel -> DailyRoutinesUiModel - RoutinesUiModel -> RoutineScheduleUiModel - 불필요한 Parcelize 제거
- SubRoutine -> SubRoutineUiModel로 클래스명 변경 - 도메인 모델을 UI 모델로 변환하는 확장 함수 추가 - WriteRoutineViewModel에서 변경된 SubRoutineUiModel을 사용하도록 수정
- Onboarding에서 사용하는 UiModel 클래스명에 `UiModel` 접미사를 추가했습니다. - Domain Model을 UiModel로 변환하는 Mapper 함수를 추가하고, 기존의 `from` 팩토리 메서드를 대체했습니다.
- Presentation 레이어에서 사용하던 ReportCategory, ReportProcess enum 클래스를 삭제하고, Domain 레이어의 모델을 직접 사용하도록 변경합니다.
- Domain Model을 UiModel로 변환하는 로직을 각 UiModel의 companion object에서 확장 함수(toUiModel)로 변경합니다.
|
Important Review skippedToo many files! This PR contains 187 files, which is 37 over the limit of 150. You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ PR Content ]
domain <-> presentation 계층간 model mapper를 구현했습니다.
Related issue
Screenshot 📸
Work Description
state,sideEffect를contract패키지 안으로 이동request,response로 통일recommendroutine서버 명세에 맞게 타입 변경(id:int->Long)routineCategory,reportCategory,ReportStatus)To Reviewers 📢