Draft
Conversation
`/volatile:ms` switch enables Microsoft extended volatile semantics that guarantee strong ordering Could add as AdditionalOptions in vcxproj files None Confirmed that the compile option is successfully set by building locally None
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Let's try turn on warning-c4746 to see if we have any compiler volatile switch dependent volatile usage in the code. |
stsoe
reviewed
Mar 5, 2026
Collaborator
stsoe
left a comment
stsoe
left a comment
There was a problem hiding this comment.
It's my understand this option is not recommended. Can you explain the reasoning behind adding this option?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Enable strong volatile ordering
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
/volatile:msswitch enables Microsoft extended volatile semantics that guarantee strong orderingHow problem was solved, alternative solutions (if any) and why they were rejected
Could add as AdditionalOptions in vcxproj files
Risks (if any) associated the changes in the commit
None
What has been tested and how, request additional testing if necessary
Confirmed that the compile option is successfully set by building locally
Documentation impact (if any)
None