Upgrade ruby version to 2.6 and stop requiring JSON#366
Open
mahmood-mq wants to merge 1 commit intoXeroAPI:masterfrom
Open
Upgrade ruby version to 2.6 and stop requiring JSON#366mahmood-mq wants to merge 1 commit intoXeroAPI:masterfrom
mahmood-mq wants to merge 1 commit intoXeroAPI:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of Ruby2.6, JSON is bundled with Ruby. Having it in the gemspec could cause version conflicts. We have faced this issues specifically with Puma in Cluster Mode. Where Puma loads the latest JSON version installed on the server, which would conflict with the JSON version in Gemfile.lock. This particularly happens on Upgrading our Downgrading JSON version, which renders Puma Phased Restarts and Hot Reload pointless.