Conversation
|
Please do not accept yet |
ReidWeb
force-pushed
the
ci/azure-pipelines
branch
from
ab25031 to
662c781
Compare
|
👍 |
|
Should be ready for acceptance once we get a passing build - configured baseline, and hooked in Jonathan's test DB. I'll look to get a docker defined test db running at some pt, and bring in the code cov stats again |
|
Sincerest apologies for the notification spam, not sure what caused that |
- Updated Unit Tests to match - Fixed Unit Test failures from updated character info
…ts/XIVStats-Gatherer-Java into ci/azure-pipelines * 'ci/azure-pipelines' of github.com:XIVStats/XIVStats-Gatherer-Java: * 'master' of github.com:XIVStats/XIVStats-Gatherer-Java: Fixed addition of DC name into World filed (#50) # Conflicts: # src/test/resources/data/lodestone/Character-2256025.html # src/test/resources/data/lodestone/Character-22763008.html
|
@matthewhillier looking at an alternate CI (Travis), having an issue with one of the tests in this run, any speculation as to the cause? |
|
Hey @ReidWeb - I think I found one test in my latest branch which had an overly-strict test against a live character (https://github.com/XIVStats/XIVStats-Gatherer-Java/pull/51/files#diff-38deaf8a51cc511381feab7299f7940cR97). I've fixed in my branch, but you may need to replicate in yours or we'll need to merge in this change. |
2 participants
No description provided.