-
Notifications
You must be signed in to change notification settings - Fork 1
Bump electron from 5.0.1 to 11.5.0 #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
2ac873d to
ecb121a
Compare
Bumps [electron](https://github.com/electron/electron) from 5.0.1 to 11.5.0. - [Release notes](https://github.com/electron/electron/releases) - [Changelog](https://github.com/electron/electron/blob/main/docs/breaking-changes.md) - [Commits](electron/electron@v5.0.1...v11.5.0) --- updated-dependencies: - dependency-name: electron dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
ecb121a to
3c9f21f
Compare
Bumps [electron](https://github.com/electron/electron) from 5.0.1 to 11.5.0. - [Release notes](https://github.com/electron/electron/releases) - [Changelog](https://github.com/electron/electron/blob/main/docs/breaking-changes.md) - [Commits](electron/electron@v5.0.1...v11.5.0) --- updated-dependencies: - dependency-name: electron dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
3c9f21f to
e6c1e72
Compare
…hub.com/XDargu/FrameByFrame into dependabot/npm_and_yarn/electron-11.5.0
|
Performance seems to be quite slow after updating to the latest electron. There are also a bunch of issues besides performance. Let's hold off this for now. |
|
A newer version of electron exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Merge missing main changes to develop
|
Performance seems to be better. I seem to have quite a few WebGL lost context issues in the latest version, but I'm not sure if it's due to the update or to my laptop GPU. Trying older versions of Frame by Frame I also get the same problem often. |
|
I have encountered more issues with the WebGL context. I suspect it has to do with starting babylon too early. Something has changed in the latest versions of electron that makes a difference. I made a few changes that delay the creation of the canvas, and it seems to work better. |
Note: when opening .fbf files with these changes, the WebGL issue is very frequent. Could be a good repro.
Bumps electron from 5.0.1 to 11.5.0.
Release notes
Sourced from electron's releases.
... (truncated)
Commits
3d0705dBump v11.5.004995cdchore: cherry-pick fix for 1231134 from chromium (#30761)b0085b1chore: cherry-pick fix for 1234009 from chromium (#30751)7576621chore: cherry-pick fix for 1233564 from chromium (#30755)de5a1d1chore: cherry-pick fix for 1234764 from v8 (#30659)585eea3fix: remove ipc wrapper for nativeImage.createThumbnailFromPath (#30738)5dbcb9fchore: cherry-pick fix for 1227933 from chromium (#30614)2502e28Bump v11.4.124e4ab9dci: update git on CI machines (#30526) (#30573)cb5c9b8Revert "Bump v11.4.12"Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and languageYou can disable automated security fix PRs for this repo from the Security Alerts page.