update to v0.6.0#69
Open
eschultink wants to merge 2 commits into
Open
Conversation
Member
Author
|
🛑 Stop! Do not merge manually.🛑 |
jlorper
reviewed
May 12, 2026
| if [[ "$JAVA_VERSION_MAJOR" != 17 && "$JAVA_VERSION_MAJOR" != 21 && "$JAVA_VERSION_MAJOR" != 23 && "$JAVA_VERSION_MAJOR" != 24 ]]; then | ||
| printf "${ERR}This Java version appears to be unsupported. You should upgrade it, or may have compile errors.${NC} Psoxy requires an Oracle-supported version of Java 17 or later; as of April 2025, this includes Java 17, 21, or 24. See https://maven.apache.org/install.html\n" | ||
| if $HOMEBREW_AVAILABLE; then printf "or as you have Homebrew available, run ${CODE}brew install openjdk@17${NC}\n"; fi | ||
| if [[ "$JAVA_VERSION_MAJOR" != 21 && "$JAVA_VERSION_MAJOR" != 25 && "$JAVA_VERSION_MAJOR" != 26 ]]; then |
Member
There was a problem hiding this comment.
I don't think we should support non LTS versions (26), then why not the ones between 21 and 25?
if [[ "$JAVA_VERSION_MAJOR" -lt 21 ]]; then
Member
Author
There was a problem hiding this comment.
22-24 are unsupported generally ... not sure we should; but yeah, i guess reasonable to just not force people to upgrade; will add back in next version.
Member
Author
There was a problem hiding this comment.
as i recall, 24 has issues w some versions of maven though ...
Member
Author
There was a problem hiding this comment.
and this is warning, not blocker.
jlorper
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update to proxy release https://github.com/Worklytics/psoxy/releases/tag/v0.6.0