Skip to content

fix: address five latent issues and remove stale BUG test comments#8

Merged
deer merged 2 commits intomainfrom
random_bug_fixes_v2
Apr 7, 2026
Merged

fix: address five latent issues and remove stale BUG test comments#8
deer merged 2 commits intomainfrom
random_bug_fixes_v2

Conversation

@deer
Copy link
Copy Markdown
Collaborator

@deer deer commented Apr 7, 2026

Seven test methods carried BUG: javadoc paragraphs documenting issues that had already been fixed in the source. Those paragraphs (and associated stale inline comments) have been removed. The tests themselves are unchanged and continue to pass.

Five fixes

  • JsonNodeInputStreamProcessor — log all three previously silent throwables via JUL instead of swallowing them.
  • LocalJDKLauncher — cache the SpawnAgent archive path in a static AtomicReference so createArchive() is called at most once per JVM rather than on every launch.
  • AbstractTemplatedPlatform.close() — actually close the internal Server. Previously a no-op, leaving the bound port open indefinitely.
  • AbstractTemplatedLauncher — log ClassNotFoundException during Iterable injection resolution instead of silently swallowing it.
  • KillContainer + new KillSignal option — add the signal query parameter to the Docker kill request. Defaults to SIGKILL (matching Docker's own default), configurable via the new KillSignal option type.

New tests: LocalMachineCloseTests (fix 3), KillContainerRequestTests (fix 5).

@deer deer merged commit a4c07f8 into main Apr 7, 2026
1 check passed
@deer deer deleted the random_bug_fixes_v2 branch April 7, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant