Skip to content

chore(spawn-local-jdk): replace auto-service with native JPMS service registration #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deer merged 1 commit into from
Apr 9, 2026
Merged

chore(spawn-local-jdk): replace auto-service with native JPMS service registration #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,5 @@ target/
# IntelliJ IDEA
.idea/
*.iml

.build/
6 changes: 1 addition & 5 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,14 +68,13 @@

<!-- Module Dependency Versions -->
<assertj.version>3.27.7</assertj.version>
<auto-service.version>1.1.1</auto-service.version>
<base.version>0.21.5</base.version>
<byte-buddy.version>1.18.4</byte-buddy.version>
<codemodel.version>0.19.0</codemodel.version>
<jackson-core.version>2.21.2</jackson-core.version>
<junit.version>6.0.3</junit.version>
<jakarta-inject.version>2.0.1</jakarta-inject.version>
<mockito.version>5.23.0</mockito.version>
<codemodel.version>0.19.0</codemodel.version>

<!-- Plugin Dependency Versions -->
<maven-compiler-plugin.version>3.15.0</maven-compiler-plugin.version>
Expand Down Expand Up @@ -340,9 +339,6 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<version>${maven-surefire-plugin.version}</version>
<configuration>
<useModulePath>false</useModulePath>
</configuration>
</plugin>

</plugins>
Expand Down
18 changes: 0 additions & 18 deletions spawn-local-jdk/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,6 @@
<description>Provides a facility to detect installed JDKs on the local platform</description>

<dependencies>
<dependency>
<groupId>com.google.auto.service</groupId>
<artifactId>auto-service-annotations</artifactId>
<version>${auto-service.version}</version>
</dependency>

<dependency>
<groupId>build.spawn</groupId>
<artifactId>spawn-application</artifactId>
Expand Down Expand Up @@ -152,18 +146,6 @@

<build>
<plugins>
<plugin>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<annotationProcessorPaths>
<path>
<groupId>com.google.auto.service</groupId>
<artifactId>auto-service</artifactId>
<version>${auto-service.version}</version>
</path>
</annotationProcessorPaths>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
Expand Down
2 changes: 0 additions & 2 deletions ...n-local-jdk/src/main/java/build/spawn/platform/local/jdk/JDKHomeBasedPatternDetector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
import build.base.foundation.Exceptional;
import build.base.logging.Logger;
import build.spawn.jdk.JDK;
import com.google.auto.service.AutoService;

import java.io.IOException;
import java.io.InputStream;
Expand Down Expand Up @@ -55,7 +54,6 @@
* @author brian.oliver
* @since Nov-2019
*/
@AutoService(JDKDetector.class)
public class JDKHomeBasedPatternDetector
implements JDKDetector {

Expand Down
2 changes: 0 additions & 2 deletions spawn-local-jdk/src/main/java/module-info.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@
* @since Jan-2025
*/
open module build.spawn.platform.local.jdk {
requires com.google.auto.service;

requires java.logging;

requires transitive build.base.foundation;
Expand Down
Loading