Fix: Comments number is wrong - Core ticket - 36409 by hbhalodia · Pull Request #9277 · WordPress/wordpress-develop

hbhalodia · 2025-07-17T08:08:15Z

Trac ticket: https://core.trac.wordpress.org/ticket/36409

Fixes

Get all the comments related to post and created the lookup based on the comment ID.
Loop through each comment and check for its child<-->parent and add only if parent comment is approved.

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

… parent

github-actions · 2025-07-17T08:08:24Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props hbhalodia, wildworks, westonruter, mukesh27, mindctrl, shailu25.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions · 2025-07-17T08:25:07Z

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

The Plugin and Theme Directories cannot be accessed within Playground.
All changes will be lost when closing a tab with a Playground instance.
All changes will be lost when refreshing the page.
A fresh instance is created each time the link below is clicked.
Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

mukeshpanchal27 · 2025-07-17T08:29:35Z

src/wp-includes/comment.php

+		/**
+		 * Get all the comments related to the post ID.
+		 */
+		$comments       = $wpdb->get_results( $wpdb->prepare( "SELECT comment_ID, comment_parent, comment_approved FROM $wpdb->comments WHERE comment_post_ID = %d", $post_id ) );


This approach could be too expensive if there are a large number of comments. Have you tested this with, for example, 1ok unapproved comments? It would be good to understand the performance impact at that scale.

I have not tested this scenario with that number of comments, I will check for the same. Also, I am not sure if we have a better solution than this? because everything is in one table like the replationships as well, SQL query would be also expensive in this case and would not cover all the deeply nested comments.

We can also do some caching with array mechanism to skip the parents that are already checked in the current approach?

Hi @mukeshpanchal27, I tested with 10K comments and it looks like it is not performant heavy, I have recorder the screencast below with the changes in PR and it looks good with not performant heavy in counting the comments, ofCourse it would take time when the actual comments are being rendered on the page.

Screen.Recording.2025-07-17.at.2.39.26.PM.mov

Thank You,

mindctrl · 2025-11-03T14:32:39Z

Can we get some phpunit tests here to show this fixes the bug and to prevent regressions?

hbhalodia · 2025-11-04T10:51:29Z

Can we get some phpunit tests here to show this fixes the bug and to prevent regressions?

Hi @mindctrl, I have added the test cases for the updated scenario.

Thank You,

shail-mehta · 2025-11-04T11:10:20Z

Can we mention ticket number in unit test?

t-hamano · 2025-11-07T12:05:09Z

@hbhalodia, Since the failure occurred in the CI, I merged the latest trunk into this pull request.

src/wp-includes/comment.php

tests/phpunit/tests/comment/wpUpdateCommentCountNow.php

Copilot

Pull request overview

This PR addresses Core ticket #36409 by changing how wp_update_comment_count_now() recalculates a post’s comment_count, aiming to exclude approved child comments when any ancestor comment is unapproved/trashed.

Changes:

Replace the direct SQL COUNT(*) in wp_update_comment_count_now() with PHP logic that checks approval status across a comment’s ancestor chain.
Add PHPUnit coverage for cases where unapproved/trashed parent comments should cause approved children to be excluded from the stored comment count.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File	Description
`src/wp-includes/comment.php`	Reworks comment counting to exclude approved descendants of unapproved ancestors (and still exclude `note` comment types).
`tests/phpunit/tests/comment/wpUpdateCommentCountNow.php`	Adds tests covering trashed/unapproved parents excluding child comments from `comment_count`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tests/phpunit/tests/comment/wpUpdateCommentCountNow.php

src/wp-includes/comment.php

tests/phpunit/tests/comment/wpUpdateCommentCountNow.php

src/wp-includes/comment.php

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

src/wp-includes/comment.php

tests/phpunit/tests/comment/wpUpdateCommentCountNow.php

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

src/wp-includes/comment.php

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Fix: Update the comment count to not include children with unapproved…

47cf2c2

… parent

Fix: PHPCS feedbacks

4bef578

mukeshpanchal27 reviewed Jul 17, 2025

View reviewed changes

hbhalodia added 2 commits November 4, 2025 14:34

Merge branch 'trunk' into fix/issue-36409-comment-count

1da3ad1

Add the test case for the updated comment count scenario

01c7ce9

hbhalodia added 2 commits November 4, 2025 16:30

Fix phpcs issue

75dbcab

Resolve phpcs multiline issue

158061f

Add ticket number to unit test

e64afba

t-hamano mentioned this pull request Nov 7, 2025

Update comment count logic to exclude unapproved comments #6431

Closed

Merge branch 'trunk' into fix/issue-36409-comment-count

1114e45

Merge branch 'trunk' into fix/issue-36409-comment-count

491e833

westonruter reviewed Feb 18, 2026

View reviewed changes

mukeshpanchal27 reviewed Feb 19, 2026

View reviewed changes

tests/phpunit/tests/comment/wpUpdateCommentCountNow.php Outdated Show resolved Hide resolved

hbhalodia added 2 commits February 19, 2026 11:01

Address feedbacks

bc41c7e

Merge branch 'trunk' into fix/issue-36409-comment-count

e4513b8

hbhalodia requested review from mukeshpanchal27 and westonruter February 19, 2026 05:34

hbhalodia and others added 3 commits February 19, 2026 11:51

Fix the tests

086c901

Fix test cases

b136e33

Merge branch 'trunk' into fix/issue-36409-comment-count

45d8fd7

westonruter requested a review from Copilot March 12, 2026 22:47

Copilot started reviewing on behalf of westonruter March 12, 2026 22:48 View session

Merge branch 'trunk' into fix/issue-36409-comment-count

97a887c

Copilot AI reviewed Mar 12, 2026

View reviewed changes

westonruter reviewed Mar 12, 2026

View reviewed changes

src/wp-includes/comment.php Outdated Show resolved Hide resolved

hbhalodia and others added 4 commits March 13, 2026 10:45

Address the feedbacks on the PR

9129e38

Merge branch 'trunk' into fix/issue-36409-comment-count

6242f4c

Fix variable name

b6689ff

Update to use memomization and reduce time complexity

c3cda23

hbhalodia requested a review from Copilot March 13, 2026 05:45

Copilot started reviewing on behalf of hbhalodia March 13, 2026 05:46 View session

Copilot AI reviewed Mar 13, 2026

View reviewed changes

hbhalodia added 2 commits March 13, 2026 11:21

Resolve copilot feedbacks

e351f6f

Cast results to array

c97aa78

hbhalodia requested a review from Copilot March 13, 2026 05:54

Copilot started reviewing on behalf of hbhalodia March 13, 2026 05:55 View session

Copilot AI reviewed Mar 13, 2026

View reviewed changes

src/wp-includes/comment.php Show resolved Hide resolved

hbhalodia requested a review from Copilot March 13, 2026 06:01

Copilot started reviewing on behalf of hbhalodia March 13, 2026 06:01 View session

Copilot AI reviewed Mar 13, 2026

View reviewed changes

hbhalodia requested a review from westonruter March 13, 2026 06:05

Conversation

hbhalodia commented Jul 17, 2025

Fixes

Uh oh!

github-actions bot commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 17, 2025

Test using WordPress Playground

Some things to be aware of

Uh oh!

mukeshpanchal27 Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

hbhalodia Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

hbhalodia Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

mindctrl commented Nov 3, 2025

Uh oh!

hbhalodia commented Nov 4, 2025

Uh oh!

shail-mehta commented Nov 4, 2025

Uh oh!

t-hamano commented Nov 7, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

github-actions bot commented Jul 17, 2025 •

edited

Loading