WP_Query::parse_query: Handle invalid query arg types - #6246
Conversation
Add unit tests.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| @@ -0,0 +1,80 @@ | |||
| <?php | |||
There was a problem hiding this comment.
[53891] introduced tests in tests/phpunit/tests/query/parseQuery.php - would it be worth following in the same place for consistency?
| $qv['feed'] = is_scalar( $qv['feed'] ) ? trim( $qv['feed'] ) : ''; | ||
| $qv['attachment'] = is_scalar( $qv['attachment'] ) ? $qv['attachment'] : ''; | ||
| $qv['author_name'] = is_scalar( $qv['author_name'] ) ? $qv['author_name'] : ''; | ||
| $qv['author__in'] = is_array( $qv['author__in'] ) ? $qv['author__in'] : array(); |
There was a problem hiding this comment.
I think this can be discarded, but I wonder if it'd be worthwhile using wp_parse_list() for these to coerce author__in=author1 (and the other QVs) into an array. wp_parse_id_list() could also be used for post__in to also absint() them early.
| $qv['author__in'] = is_array( $qv['author__in'] ) ? $qv['author__in'] : array(); | |
| $qv['author__in'] = wp_parse_list( $qv['author__in'] ); |
|
I added another approach in #12738 |
Add
is_scalar/is_arraychecks.Trac ticket: https://core.trac.wordpress.org/ticket/60745
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.