Skip to content

Build/Test Tools: Reference reusable-prepare-gutenberg.yml at trunk in the 7.0 PHPUnit workflow - #12743

Open
lancewillett wants to merge 2 commits into
WordPress:7.0from
lancewillett:fix/prepare-gutenberg-trunk-ref-7.0
Open

Build/Test Tools: Reference reusable-prepare-gutenberg.yml at trunk in the 7.0 PHPUnit workflow#12743
lancewillett wants to merge 2 commits into
WordPress:7.0from
lancewillett:fix/prepare-gutenberg-trunk-ref-7.0

Conversation

@lancewillett

Copy link
Copy Markdown
Contributor

This updates the 7.0 PHPUnit workflow to reference reusable-prepare-gutenberg.yml@trunk instead of a pinned commit SHA.

The reusable-phpunit-tests-v3.yml callers already use @trunk. Keeping both shared workflows on the same ref prevents their output contract from drifting and preserves the one-version-to-maintain intent.

No PHP matrix or caller wiring changed.

Trac ticket: https://core.trac.wordpress.org/ticket/65721

Testing

  • actionlint .github/workflows/phpunit-tests.yml
  • git diff --check

Use of AI Tools

AI assistance: Yes
Tool(s): Codex
Model(s): GPT-5
Used for: Applied and validated the one-line workflow reference change. The final diff was reviewed by me.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request.

Comment thread .github/workflows/phpunit-tests.yml Fixed
@lancewillett
lancewillett marked this pull request as ready for review July 28, 2026 22:16
@lancewillett
lancewillett requested a review from Copilot July 28, 2026 22:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GitHub Actions 7.0 PHPUnit workflow to track the reusable-prepare-gutenberg.yml reusable workflow on trunk (instead of a pinned commit), aiming to keep the “prepare” producer aligned with other PHPUnit workflow consumers already following @trunk.

Changes:

  • Switch prepare-gutenberg to use reusable-prepare-gutenberg.yml@trunk rather than a pinned SHA.
  • Add an inline note and a zizmor suppression for the unpinned uses: reference.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

prepare-gutenberg:
uses: WordPress/wordpress-develop/.github/workflows/reusable-prepare-gutenberg.yml@80fb78da3153431dee7e5d66e7463e71fda31ec7
# Keep the producer aligned with the consumer workflows that also follow trunk.
uses: WordPress/wordpress-develop/.github/workflows/reusable-prepare-gutenberg.yml@trunk # zizmor: ignore[unpinned-uses]
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props lancewillett.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

.github/workflows/phpunit-tests.yml:67

  • The inline zizmor: ignore[unpinned-uses] suppression appears to be unused/inconsistent in this repo: this is the only zizmor: annotation, and there are multiple other uses: ...@trunk entries in this workflow and others without suppression. Consider removing the suppression to avoid confusion (or, if zizmor is actually enforced, suppress/pin consistently across all similar uses: lines).
    uses: WordPress/wordpress-develop/.github/workflows/reusable-prepare-gutenberg.yml@trunk # zizmor: ignore[unpinned-uses]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants