Skip to content

Options, Meta APIs: Support plural forms for count labels in Settings. #12731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
t-hamano wants to merge 1 commit into
base: trunk
Choose a base branch
from
+33 −5
Open

Options, Meta APIs: Support plural forms for count labels in Settings. #12731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/wp-admin/options-discussion.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,10 +184,17 @@
<td><fieldset><legend class="screen-reader-text"><span><?php echo $comment_moderation_title; ?></span></legend>
<p><label for="comment_max_links">
<?php
$comment_max_links = (int) get_option( 'comment_max_links' );
printf(
/* translators: %s: Number of links. */
__( 'Hold a comment in the queue if it contains %s or more links. (A common characteristic of comment spam is a large number of hyperlinks.)' ),
'<input name="comment_max_links" type="number" step="1" min="0" id="comment_max_links" value="' . esc_attr( get_option( 'comment_max_links' ) ) . '" class="small-text" />'
translate_nooped_plural(
/* translators: %s: Number field for the maximum number of links. */
_n_noop(
'Hold a comment in the queue if it contains %s or more link. (A common characteristic of comment spam is a large number of hyperlinks.)',
'Hold a comment in the queue if it contains %s or more links. (A common characteristic of comment spam is a large number of hyperlinks.)'
Comment on lines +192 to +193
),
$comment_max_links
),
'<input name="comment_max_links" type="number" step="1" min="0" id="comment_max_links" value="' . esc_attr( $comment_max_links ) . '" class="small-text" />'
);
?>
</label></p>
Expand Down
25 changes: 23 additions & 2 deletions src/wp-admin/options-reading.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,12 +177,33 @@
<tr>
<th scope="row"><label for="posts_per_page"><?php _e( 'Blog pages show at most' ); ?></label></th>
<td>
<input name="posts_per_page" type="number" step="1" min="1" id="posts_per_page" value="<?php form_option( 'posts_per_page' ); ?>" class="small-text" /> <?php _e( 'posts' ); ?>
<?php $posts_per_page = (int) get_option( 'posts_per_page' ); ?>
<input name="posts_per_page" type="number" step="1" min="1" id="posts_per_page" value="<?php echo esc_attr( $posts_per_page ); ?>" class="small-text" />
<?php
echo esc_html(
translate_nooped_plural(
/* translators: Number of posts, used as a label after the "Blog pages show at most" number field. */
_n_noop( 'post', 'posts' ),
$posts_per_page
)
);
?>
</td>
</tr>
<tr>
<th scope="row"><label for="posts_per_rss"><?php _e( 'Syndication feeds show the most recent' ); ?></label></th>
<td><input name="posts_per_rss" type="number" step="1" min="1" id="posts_per_rss" value="<?php form_option( 'posts_per_rss' ); ?>" class="small-text" /> <?php _e( 'items' ); ?></td>
<td><?php $posts_per_rss = (int) get_option( 'posts_per_rss' ); ?>
<input name="posts_per_rss" type="number" step="1" min="1" id="posts_per_rss" value="<?php echo esc_attr( $posts_per_rss ); ?>" class="small-text" />
<?php
echo esc_html(
translate_nooped_plural(
/* translators: Number of items, used as a label after the "Syndication feeds show the most recent" number field. */
_n_noop( 'item', 'items' ),
$posts_per_rss
)
);
?>
</td>
</tr>

<?php $rss_use_excerpt_title = __( 'For each post in a feed, include' ); ?>
Expand Down
Loading