Skip to content

Add unit tests for insert_with_markers() in src/wp-admin/includes/mis…#11659

Open
pbearne wants to merge 2 commits intoWordPress:trunkfrom
pbearne:65137-misc-insert_with_markers
Open

Add unit tests for insert_with_markers() in src/wp-admin/includes/mis…#11659
pbearne wants to merge 2 commits intoWordPress:trunkfrom
pbearne:65137-misc-insert_with_markers

Conversation

@pbearne
Copy link
Copy Markdown

@pbearne pbearne commented Apr 27, 2026

…c.php
This PR adds comprehensive unit tests for the insert_with_markers() function in src/wp-admin/includes/misc.php.

The tests cover:

  • New file creation with markers.
  • Insertion into an existing file without a marker block.
  • Replacement of an existing marker block.
  • Handling of WordPress-specific warning comments.
  • Empty insertions (removing content but keeping markers).
  • Handling of non-writable files.
  • Support for both string and array insertions.

Trac ticket: https://core.trac.wordpress.org/ticket/65137

Use of AI Tools

AI assistance: Yes
Tool(s): Junie (JetBrains)
Model(s): gemini-3-flash-preview
Used for: Test structure generation, dataProvider implementation, and local environment verification. All tests were verified against WordPress core standards and run in the local Docker environment.

@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @pbearne@git.wordpress.org.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant