Skip to content

Add unit tests for got_mod_rewrite() in src/wp-admin/includes/misc.php#11656

Open
pbearne wants to merge 3 commits intoWordPress:trunkfrom
pbearne:65134-misc-got_mod_rewrite
Open

Add unit tests for got_mod_rewrite() in src/wp-admin/includes/misc.php#11656
pbearne wants to merge 3 commits intoWordPress:trunkfrom
pbearne:65134-misc-got_mod_rewrite

Conversation

@pbearne
Copy link
Copy Markdown

@pbearne pbearne commented Apr 27, 2026

Reference: https://core.trac.wordpress.org/ticket/65134

This PR adds comprehensive unit tests for the got_mod_rewrite() function in src/wp-admin/includes/misc.php.
The tests cover:

  • Default behaviour based on Apache module detection.
  • Overriding behaviour using the got_rewrite filter.

Trac ticket: https://core.trac.wordpress.org/ticket/65134

Use of AI Tools

AI assistance: Yes
Tool(s): Junie (JetBrains)
Model(s): gemini-3-flash-preview
Used for: Identifying untested functions, generating the test skeleton, and implementing the dataProvider logic. All code was reviewed and verified against WordPress core testing patterns.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 27, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @pbearne@git.wordpress.org.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props pbearne.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@pbearne pbearne force-pushed the 65134-misc-got_mod_rewrite branch 2 times, most recently from 0f781a9 to c3cb218 Compare April 27, 2026 18:31
@pbearne pbearne force-pushed the 65134-misc-got_mod_rewrite branch from 78e67a3 to 7f341bd Compare April 27, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant