Always download the appropriate artifact#11221
Always download the appropriate artifact#11221desrosj wants to merge 1 commit intoWordPress:trunkfrom
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
eeb4da0 to
85076b2
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
85076b2 to
3abcfa8
Compare
ockham
left a comment
There was a problem hiding this comment.
LGTM, and behaves as advertised in my local testing!
Disclaimer: I'm not super-familiar with the "new" build system and GB code sync, but AFAICS, the changes make sense to me.
This PR aims to prevent a failure when
npm installis run when either the directory already exists or the thegutenberg/.gutenberg-hashfile is missing (which means the script cannot currently confirm the correct version of the Gutenberg plugin is present).postinstallcommand is changed fromgutenberg:downloadtogutenberg:verify.--forceoption has been removed.gutenberg:downloadwill now download a fresh copy every time it's run.gutenberg:verifyscript is now the preferred entry point for managing the files within thegutenbergdirectory. It will only trigger a downoad if the hashes do not match, or the folder is missing entirely.Trac ticket: Core-64393.
Use of AI Tools
Claude was used to create the initial draft for this PR.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.