Skip to content

#64832 Fix Upload Plugin form layout use flex box for file and submit #11216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PANawkar wants to merge 1 commit into
base: trunk
Choose a base branch
from
+47 −26
Open

#64832 Fix Upload Plugin form layout use flex box for file and submit #11216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 39 additions & 22 deletions src/wp-admin/css/themes.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1135,25 +1135,36 @@ body.folded .theme-browser ~ .theme-overlay .theme-wrap {

.upload-theme .wp-upload-form,
.upload-plugin .wp-upload-form {
position: relative;
margin: 30px auto;
display: inline-flex;
justify-content: space-between;
align-items: center;
display: inline-block;
}

.upload-theme .wp-upload-form input[type="file"],
.upload-plugin .wp-upload-form input[type="file"] {
.upload-theme .wp-upload-form .wp-upload-form-box,
.upload-plugin .wp-upload-form .wp-upload-form-box {
box-sizing: border-box;
display: flex;
flex-wrap: nowrap;
align-items: center;
gap: 15px;
background: #f6f7f7;
border: 1px solid #c3c4c7;
margin: 0;
padding: 30px 128px 30px 30px;
border: 1px solid #c3c4c7;
margin: 0;
padding: 30px;
}

.upload-plugin .wp-upload-form input[type=submit],
.upload-theme .wp-upload-form input[type=submit] {
position: absolute;
right: 30px;
.upload-theme .wp-upload-form .wp-upload-form-box input[type="file"],
.upload-plugin .wp-upload-form .wp-upload-form-box input[type="file"] {
background: transparent;
border: none;
margin: 0;
padding: 0;
flex: 1;
min-width: 0;
}

.upload-plugin .wp-upload-form .wp-upload-form-box input[type="submit"],
.upload-theme .wp-upload-form .wp-upload-form-box input[type="submit"] {
flex-shrink: 0;
}

.upload-theme .install-help,
Expand Down Expand Up @@ -1191,6 +1202,7 @@ p.no-themes-local {
.upload-theme .wp-upload-form {
margin: 20px 0;
max-width: 100%;
display: block;
}
.upload-theme .install-help {
font-size: 15px;
Expand Down Expand Up @@ -2071,19 +2083,24 @@ body.full-overlay-active {
.upload-plugin .wp-upload-form,
.upload-theme .wp-upload-form {
width: 100%;
display: block;
}

.upload-plugin .wp-upload-form input[type=file],
.upload-theme .wp-upload-form input[type=file] {
padding: 30px 30px 80px;
.upload-plugin .wp-upload-form .wp-upload-form-box,
.upload-theme .wp-upload-form .wp-upload-form-box {
width: 100%;
flex-direction: column;
align-items: stretch;
padding: 30px;
}

:is(.upload-theme, .upload-plugin) .wp-upload-form input[type="submit"].button {
right: unset;
left: 50%;
transform: translateX(-50%) !important;
top: calc( 1.4em + 42px ); /* Line height of control + gap + top padding. */
margin: 10px 0 0;
.upload-plugin .wp-upload-form .wp-upload-form-box input[type=file],
.upload-theme .wp-upload-form .wp-upload-form-box input[type=file] {
width: 100%;
}

:is(.upload-theme, .upload-plugin) .wp-upload-form .wp-upload-form-box input[type="submit"].button {
align-self: center;
margin-top: 10px;
}
}
6 changes: 4 additions & 2 deletions src/wp-admin/includes/plugin-install.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,8 +351,10 @@ function install_plugins_upload() {
_e( 'Plugin zip file' );
?>
</label>
<input type="file" id="pluginzip" name="pluginzip" accept=".zip" />
<?php submit_button( _x( 'Install Now', 'plugin' ), '', 'install-plugin-submit', false ); ?>
<div class="wp-upload-form-box">
<input type="file" id="pluginzip" name="pluginzip" accept=".zip" />
<?php submit_button( _x( 'Install Now', 'plugin' ), '', 'install-plugin-submit', false ); ?>
</div>
</form>
</div>
<?php
Expand Down
6 changes: 4 additions & 2 deletions src/wp-admin/includes/theme-install.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,8 +203,10 @@ function install_themes_upload() {
_e( 'Theme zip file' );
?>
</label>
<input type="file" id="themezip" name="themezip" accept=".zip" />
<?php submit_button( _x( 'Install Now', 'theme' ), '', 'install-theme-submit', false ); ?>
<div class="wp-upload-form-box">
<input type="file" id="themezip" name="themezip" accept=".zip" />
<?php submit_button( _x( 'Install Now', 'theme' ), '', 'install-theme-submit', false ); ?>
</div>
</form>
<?php
}
Expand Down
Loading