Fixes #64825: Twenty Seventeen: Stop passing get_the_ID() to twentyseventeen_edit_link(), simplify docblock. #11209
Fixes #64825: Twenty Seventeen: Stop passing get_the_ID() to twentyseventeen_edit_link(), simplify docblock. #11209PANawkar wants to merge 2 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @pratik.nawkar@xecurify.com. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| * Returns an accessibility-friendly link to edit a post or page. | ||
| * | ||
| * This also gives a little context about what exactly we're editing | ||
| * (post or page?) so that users understand a bit more where they are in terms | ||
| * of the template hierarchy and their content. Helpful when/if the single-page | ||
| * layout with multiple posts/pages shown gets confusing. |
There was a problem hiding this comment.
I think the documentation update is more important than a PHPStan-related change. The function does not give any page/post context since that was removed in PR 89, before version 1.0.
mukeshpanchal27
left a comment
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Looks good.
The function documentation update just needs to be reverted, and then it should be ready for commit.
Co-authored-by: Stephen A. Bernhardt <sabernhardt@yahoo.com>
3 participants
Stop passing get_the_ID() to twentyseventeen_edit_link()
Trac ticket: https://core.trac.wordpress.org/ticket/64825