Repository navigation
Align format names in sas7bcat with sas7bdat and xport - #424
Merged
Merged
Conversation
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
This PR is part of the effort to ensure that all SAS data files (sas7bdat) written by pyreadstat (which of course wraps ReadStat) are readable by SAS: Roche/pyreadstat#205
The other currently open PR related to this is #423.
If we merge these two PRs (with fixes as needed of course), then my bug list from testing Roche/pyreadstat#205 will be empty. More things might still pop up during final testing but I'm quite optimistic at the moment.
Problem
The PRs #415 for XPT files and #419 for sas7bdat files aligned the presentation of SAS format names with how SAS itself does it. And #419 also prevented the writing of invalid SAS data files by rejecting invalid format names.
This PR now aligns the format names in SAS catalog files (sas7bcat) with the other two formats. The added validation in the writer is again added to prevent the writing of SAS files that are rejected by SAS.