Skip to content

docs: visibility:public now supported on POST /v1/data/prepare#53

Merged
JimCollinson merged 2 commits into
mainfrom
claude/prose-2026-05-28-data-prepare-public
May 28, 2026
Merged

docs: visibility:public now supported on POST /v1/data/prepare#53
JimCollinson merged 2 commits into
mainfrom
claude/prose-2026-05-28-data-prepare-public

Conversation

@JimCollinson
Copy link
Copy Markdown
Collaborator

Upstream

  • ant-sdk: 7a113b390522d76d28b8f3e5b4078f9c9418d46f7853b76d99ef9e308140b763f23d043559b204c4

Source artifacts inspected

  • antd/src/rest/upload.rs — 501 guard removed; data_prepare_upload_with_visibility(data, visibility) called for all visibility values
  • antd/src/types.rsPrepareDataUploadRequest.visibility doc comment updated to reflect full support
  • antd-rust/src/client.rsprepare_data_upload doc comment updated (removed "returns 501 until upstream ant-client #73")

Developer-facing change

POST /v1/data/prepare now accepts visibility:"public". Previously the endpoint returned 501 for that value (pending ant-client #73). With this merge, the serialized DataMap is bundled into the same external-signer payment batch and published on-network on finalize; the data_map_address field is populated in the finalize response.

Files changed in this PR

  • docs/sdk/reference/rest-api.md — updated visibility parameter description for POST /v1/data/prepare; removed 501 row from error codes table
  • docs/sdk/how-to-guides/use-external-signers-for-upload-payments.md — removed "only private uploads" / "returns 501" claim; updated to describe current behavior

Why prose changed

docs/sdk/reference/rest-api.md: The parameter table for POST /v1/data/prepare stated "public" returns 501. This is now incorrect: the implementation calls data_prepare_upload_with_visibility and handles "public" the same way file uploads do. The 501 error code row in the error codes table was also tied exclusively to this endpoint and was removed. Tracks antd/src/rest/upload.rs and antd/src/types.rs at 7853b76.

docs/sdk/how-to-guides/use-external-signers-for-upload-payments.md: The guide stated "the in-memory data prepare endpoint supports only private uploads" and directed readers to use /v1/upload/prepare for public external-signer uploads. The restriction no longer exists; both endpoints now behave symmetrically for visibility:"public". Tracks antd/src/rest/upload.rs at 7853b76.

Verification run

  • Re-ran python3 scripts/sweep_poll.py on this branch: status: "ok", both prose-PR pages now show drifted: false.
  • Confirmed no 501 references remain for the visibility:"public" limitation on /v1/data/prepare in either updated file.
  • Confirmed skills/start/SKILL.md body is byte-identical to base — no linked release triggered.
  • No markdown linter configured; skipped.
  • No link checker configured; skipped.

Deferred ambiguous records

None.

Uncertainties

The antd/openapi.yaml at head_sha still shows 501 for visibility:"public" on /v1/data/prepare — the spec lags the implementation by at least one commit. The prose changes here follow the actual runtime code. A reviewer may wish to file an upstream issue to bring the OpenAPI spec in sync.


Generated by Claude Code

claude and others added 2 commits May 28, 2026 08:11
The daemon now supports visibility:"public" on POST /v1/data/prepare.
The 501 guard (blocked on ant-client #73) was removed at ant-sdk
7853b76; data_prepare_upload_with_visibility is now called for all
visibility values on that endpoint.

Update the REST API reference and the external-signer how-to guide
to reflect the current behavior: "public" bundles the serialized
DataMap into the same payment batch and publishes it on finalize,
with data_map_address returned in the finalize response.

Verified against ant-sdk@7853b76d99ef9e308140b763f23d043559b204c4
@JimCollinson JimCollinson marked this pull request as ready for review May 28, 2026 08:34
@JimCollinson JimCollinson merged commit cc7240f into main May 28, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants