docs: visibility:public now supported on POST /v1/data/prepare#53
Merged
Merged
Conversation
The daemon now supports visibility:"public" on POST /v1/data/prepare. The 501 guard (blocked on ant-client #73) was removed at ant-sdk 7853b76; data_prepare_upload_with_visibility is now called for all visibility values on that endpoint. Update the REST API reference and the external-signer how-to guide to reflect the current behavior: "public" bundles the serialized DataMap into the same payment batch and publishes it on finalize, with data_map_address returned in the finalize response. Verified against ant-sdk@7853b76d99ef9e308140b763f23d043559b204c4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream
7a113b390522d76d28b8f3e5b4078f9c9418d46f→7853b76d99ef9e308140b763f23d043559b204c4Source artifacts inspected
antd/src/rest/upload.rs— 501 guard removed;data_prepare_upload_with_visibility(data, visibility)called for all visibility valuesantd/src/types.rs—PrepareDataUploadRequest.visibilitydoc comment updated to reflect full supportantd-rust/src/client.rs—prepare_data_uploaddoc comment updated (removed "returns 501 until upstream ant-client #73")Developer-facing change
POST /v1/data/preparenow acceptsvisibility:"public". Previously the endpoint returned 501 for that value (pending ant-client #73). With this merge, the serialized DataMap is bundled into the same external-signer payment batch and published on-network on finalize; thedata_map_addressfield is populated in the finalize response.Files changed in this PR
docs/sdk/reference/rest-api.md— updated visibility parameter description forPOST /v1/data/prepare; removed 501 row from error codes tabledocs/sdk/how-to-guides/use-external-signers-for-upload-payments.md— removed "only private uploads" / "returns 501" claim; updated to describe current behaviorWhy prose changed
docs/sdk/reference/rest-api.md: The parameter table forPOST /v1/data/preparestated"public"returns501. This is now incorrect: the implementation callsdata_prepare_upload_with_visibilityand handles"public"the same way file uploads do. The 501 error code row in the error codes table was also tied exclusively to this endpoint and was removed. Tracksantd/src/rest/upload.rsandantd/src/types.rsat7853b76.docs/sdk/how-to-guides/use-external-signers-for-upload-payments.md: The guide stated "the in-memory data prepare endpoint supports only private uploads" and directed readers to use/v1/upload/preparefor public external-signer uploads. The restriction no longer exists; both endpoints now behave symmetrically forvisibility:"public". Tracksantd/src/rest/upload.rsat7853b76.Verification run
python3 scripts/sweep_poll.pyon this branch:status: "ok", both prose-PR pages now showdrifted: false./v1/data/preparein either updated file.skills/start/SKILL.mdbody is byte-identical to base — no linked release triggered.Deferred ambiguous records
None.
Uncertainties
The
antd/openapi.yamlathead_shastill shows 501 forvisibility:"public"on/v1/data/prepare— the spec lags the implementation by at least one commit. The prose changes here follow the actual runtime code. A reviewer may wish to file an upstream issue to bring the OpenAPI spec in sync.Generated by Claude Code