feat!: depend on bootstrap-cache removal chain#119
Open
mickvandijke wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This breaking PR removes ant-node’s local bootstrap-cache integration to align with upstream saorsa-core/ant-protocol bootstrap-cache removal work, while preserving deterministic bootstrap peer discovery when an explicit env-var path is supplied.
Changes:
- Switches
ant-protocol,saorsa-core, and transitive lockfile entries to bootstrap-cache-removal git branches. - Removes bootstrap-cache config, CLI flags, public re-export,
BootstrapManagerconstruction, and shutdown stats logging. - Refactors bootstrap peer auto-discovery so
ANT_BOOTSTRAP_PEERS_PATHacts as an exclusive override.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
Cargo.toml |
Points core protocol dependencies at bootstrap-cache-removal branches. |
Cargo.lock |
Updates locked dependency sources/revisions for the git dependency chain. |
src/node.rs |
Removes BootstrapManager wiring and shutdown cache telemetry. |
src/config.rs |
Removes BootstrapCacheConfig and changes bootstrap peer discovery behavior. |
src/lib.rs |
Removes public BootstrapCacheConfig re-export. |
src/bin/ant-node/cli.rs |
Removes bootstrap-cache CLI options and config mapping. |
docs/DESIGN.md |
Removes stale BootstrapManager references from design documentation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| XorName, | ||
| }; | ||
| pub use config::{BootstrapCacheConfig, NodeConfig, StorageConfig}; | ||
| pub use config::{NodeConfig, StorageConfig}; |
Comment on lines
+522
to
+523
| if let Ok(env_path) = std::env::var(BOOTSTRAP_PEERS_ENV) { | ||
| return Self::load_non_empty_candidate(PathBuf::from(env_path)); |
BREAKING CHANGE: removes ant-node bootstrap-cache config, CLI flags, and manager integration while updating ant-node to the ant-protocol and saorsa-core bootstrap-cache removal branches.
mickvandijke
force-pushed
the
codex/remove-bootstrap-cache
branch
from
0387e46 to
265d6a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependency PRs
Verification