library: stop gamepad buttons other than A from confirming in the gam… - #782
Merged
Merged
Conversation
…e screen The game detail/Play screen moves Android focus with the D-pad and handles no gamepad keys, so Android re-sent unhandled buttons as their Generic.kcm fallbacks: Y as SPACE and Start/L3/R3 as DPAD_CENTER, which all clicked the focused control, while X (DEL) and Select (MENU) did nothing. controllerConfirmOnA() consumes every gamepad button except A, B and Guide when no control claims it. It covers the game screen, its source menu popup and the retro save transfer dialog. DialogPaneNav now also keeps L3/R3 from falling back into an activate, and controllerMenuInput uses the same rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e screen
The game detail/Play screen moves Android focus with the D-pad and handles no gamepad keys, so Android re-sent unhandled buttons as their Generic.kcm fallbacks: Y as SPACE and Start/L3/R3 as DPAD_CENTER, which all clicked the focused control, while X (DEL) and Select (MENU) did nothing.
controllerConfirmOnA() consumes every gamepad button except A, B and Guide when no control claims it. It covers the game screen, its source menu popup and the retro save transfer dialog. DialogPaneNav now also keeps L3/R3 from falling back into an activate, and controllerMenuInput uses the same rule.