Skip to content

Conversation

@HectorCorbellini
Copy link

@HectorCorbellini HectorCorbellini commented Aug 1, 2025

This commit removes the obsolete TapirLink and GBIF exposure UI functionality from the application.

The following changes were made:

  • Deleted the EncounterSetTapirLinkExposure and MassExposeGBIF servlets.
  • Removed all related servlet mappings, security constraints, and Shiro filter rules from web.xml.
  • Cleaned up UI elements from admin.jsp.
  • Removed localization keys from all header.properties resource bundles.
  • Stripped orphaned code references from Encounter.java and CommonConfiguration.java.

This work fully addresses the cleanup requested in the associated issues.

Fixes #356
Fixes #401

All procedures done to make this improvements are explained at ANALYSIS.md

Before you Submit!

  • Is all the text internationalized?
  • If you made a change to the header, did you update the react, jsp, and html?
  • Are all dependencies at a locked version?
  • Did you adhere to best practices?
  • Is there a quick unit test you can add?

@HectorCorbellini HectorCorbellini force-pushed the feature/remove-tapirlink-gbif-ui branch from ccd238a to 5147a07 Compare August 2, 2025 02:56
@HectorCorbellini HectorCorbellini force-pushed the feature/remove-tapirlink-gbif-ui branch 2 times, most recently from fc43be9 to 38be80d Compare August 2, 2025 03:41
@vkirkl
Copy link
Contributor

vkirkl commented Aug 4, 2025

Hi @HectorCorbellini - this pr changes the file mode for every file (note the "Files changed 1,359"). Can you please update it so it leaves the file modes unchanged and only contains the relevant code changes? Thank you!

@HectorCorbellini
Copy link
Author

HectorCorbellini commented Aug 4, 2025 via email

@HectorCorbellini HectorCorbellini force-pushed the feature/remove-tapirlink-gbif-ui branch from 38be80d to 866cc65 Compare August 5, 2025 04:17
@HectorCorbellini
Copy link
Author

HectorCorbellini commented Aug 5, 2025 via email

@HectorCorbellini
Copy link
Author

HectorCorbellini commented Aug 8, 2025 via email

@vkirkl
Copy link
Contributor

vkirkl commented Aug 8, 2025

Thanks @HectorCorbellini! Let us know when you've pushed your updates and we'll do a cr.

@HectorCorbellini
Copy link
Author

HectorCorbellini commented Aug 12, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove tapirlink Expose to GBIF is still visible

3 participants