Repository navigation
Add source map to Responsive-Design workload, generate resources.txt during build - #599
Merged
Merged
Conversation
The build deletes dist/ before bundling, so it also deleted the checked-in resources.txt. Emit it from a Rollup plugin, as the ChatRoom workload does.
Lit's npm packages ship minified code with per-file source maps. Load those maps during the build so that the bundle's map resolves to Lit's TypeScript sources.
✅ Deploy Preview for webkit-speedometer-preview ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
camillobruni
self-requested a review
November 12, 2026 14:09
camillobruni
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Responsive-Design workload didn't have a source map. Also, rebuilding it was discarding resources.txt.