Skip to content

Harden GitHub Actions CI workflow against supply-chain risks #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
camillobruni wants to merge 1 commit into
base: main
Choose a base branch
from
+25 −10
Open

Harden GitHub Actions CI workflow against supply-chain risks #593

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 25 additions & 10 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,24 @@ on:
# Allows you to run this workflow manually from the Actions tab
workflow_dispatch:

permissions:
contents: read

env:
NPM_CONFIG_IGNORE_SCRIPTS: "true"
NPM_CONFIG_AUDIT: "false"
NPM_CONFIG_FUND: "false"

jobs:
linters:
name: Linters
runs-on: macos-latest
timeout-minutes: 15
steps:
- name: Checkout Branch
uses: actions/checkout@v4
with:
persist-credentials: false

- name: Setup Node
uses: actions/setup-node@v4
Expand All @@ -24,7 +35,7 @@ jobs:
cache: "npm"

- name: Install Node Packages
run: npm ci
run: npm ci --ignore-scripts

- name: Run package.json linter
run: npm run lint:pkg
Expand All @@ -38,7 +49,7 @@ jobs:
if [ -n "$git_status" ]; then
printf "Some file(s) changed as the result of formatting, this means that you need to run the formatter on your patch.\n"
printf "Here is what changed:\n"
printf -- "$git_status\n\n"
printf "%s\n\n" "$git_status"
printf "And here is the diff:\n"
git diff -U8
exit 1
Expand All @@ -47,9 +58,12 @@ jobs:
test-node:
name: Node Unit Tests
runs-on: ubuntu-latest
timeout-minutes: 15
steps:
- name: Checkout Branch
uses: actions/checkout@v4
with:
persist-credentials: false

- name: Setup Node
uses: actions/setup-node@v4
Expand All @@ -58,24 +72,25 @@ jobs:
cache: "npm"

- name: Install Node Packages
run: npm ci
run: npm ci --ignore-scripts

- name: Run Node Unit Tests
run: npm test

build:
name: Build
runs-on: macos-latest
timeout-minutes: 30
strategy:
matrix:
browser: [chrome, firefox, safari]
env:
BROWSER: ${{ matrix.browser }}
steps:
- name: Install Firefox
if: ${{ matrix.browser == 'firefox' }}
run: brew install --cask firefox

- name: Checkout Branch
uses: actions/checkout@v4
with:
persist-credentials: false

- name: Setup Node
uses: actions/setup-node@v4
Expand All @@ -84,14 +99,14 @@ jobs:
cache: "npm"

- name: Install Node Packages
run: npm ci
run: npm ci --ignore-scripts

- name: Run Unit Tests
run: |
echo "Running in $BROWSER"
npm run test:${{ matrix.browser }}
npm run "test:$BROWSER"

- name: Run end2end Tests
run: |
echo "Running in $BROWSER"
npm run test-e2e:${{ matrix.browser }}
npm run "test-e2e:$BROWSER"
Loading