Move solver to service package - #1719
Open
agusaldasoro wants to merge 4 commits into
Open
Conversation
agusaldasoro
marked this pull request as ready for review
August 27, 2026 18:35
arcuri82
approved these changes
Aug 27, 2026
arcuri82
requested changes
Aug 27, 2026
arcuri82
left a comment
Collaborator
There was a problem hiding this comment.
@agusaldasoro hi. there are merge conflicts
Collaborator
Author
Fixed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1696 (comment).
docs/for_developers.mdasks that injectable services be singletons declared under a*.servicepackage.SMTLibZ3DbConstraintSolveralready met the first two conditions:BaseModulebinds it withasEagerSingleton(), andApiWsStructureMutatorinjects it. Only the package was wrong, so it moves toorg.evomaster.core.database.sql.solver.service.It is the only injectable in that package.
SmtLibGenerator,SMTConditionVisitor,SmtTableand theDbConstraintSolverinterface have no binding and nothing injects them, so they stay where they are. The moved file picks up two imports for the symbols it used to reach as package mates, and the rest of the production change is two import lines, inBaseModuleandApiWsStructureMutator. Nothing names the class as a string anywhere, so the Guice binding resolves exactly as before, and no behaviour changes.Tests moved to match
The solver tests sat in
org.evomaster.core.solver, a package matching nothing in production. Since a test suite is meant to live in the same package as its class under test, all ten move as well:SMTLibZ3DbConstraintSolverTestandUntranslatableQueryCacheTestinto...sql.solver.service, and the eight covering the generator, the visitor and the shared type vocabulary into...sql.solver. Imports that became same-package are dropped. The corpus and scaling tests load their fixtures by absolute classpath path (/solver/sample-schema.json), so those are unaffected and the resources stay where they are.